Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiery Touch upgrade tweak #1088

Closed
DreadKnight opened this issue Oct 11, 2016 · 18 comments
Closed

Fiery Touch upgrade tweak #1088

DreadKnight opened this issue Oct 11, 2016 · 18 comments
Labels
abilities The issue is related to an unit ability or more coding This issue requires some programming priority This should get fixed as soon as possible!

Comments

@DreadKnight
Copy link
Member

DreadKnight commented Oct 11, 2016

Abolished's Fiery Touch should be tweaked:

  • the ability is a ranged attack, hits 1 hex
  • forward, backwards + diagonal targeting
  • regular hit should do 15 slash + 15 burn
  • regular hit should have 3 hexagons range
  • upgraded can do extra 3 hexagons range
  • the extra range of the upgrade only does the 15 burn damage part
  • the extra range for the upgrade should be indicated by scaled down hexagons

tweaked Fiery Touch

@DreadKnight DreadKnight added coding This issue requires some programming abilities The issue is related to an unit ability or more labels Oct 11, 2016
@DreadKnight DreadKnight added this to the 0.4 - Bounty Hunter milestone Oct 11, 2016
@DreadKnight DreadKnight added this to Abolished in unit balancing Mar 30, 2017
DreadKnight added a commit that referenced this issue Jun 25, 2018
DreadKnight added a commit that referenced this issue Jun 25, 2018
@DreadKnight DreadKnight added the priority This should get fixed as soon as possible! label Jun 25, 2018
@tristanmkernan
Copy link
Collaborator

  • If the target unit is one hexagon away, apply scratch damage and burn damage / effect
    • this is true for the unupgraded and upgraded ability
  • when the ability is selected, show what exactly? are there other abilities that function like this?

@DreadKnight
Copy link
Member Author

DreadKnight commented Jun 26, 2018

@russon77 regarding first one, if the unit is up to 3 hexagons distance, meaning there can be up to 3 empty hexagons between Abolished and the target unit, as it has a long hand and can reach further.

Regarding second point, no, but Chimera's Disturbing Sound displays full hexagons up until the first target, then dashed ones as the projectile might continue to next ones if the initial target gets killed.
When the ability is selected, provided target is in range, it should show up to 3 filled hexagons and up to 4 dashed ones (4th one being the target unit).

Animation wise, Abolished will stretch hand up to a few hexagons and if not hitting anything, the fire from its hand will continue a few hexagons more, so it's a fireball throw in a way, kinda like a water splash :D

I might edit the ability and/or upgrade descriptions to improve them or tweak the ranges a bit in the future.

@DreadKnight
Copy link
Member Author

This issue is up for grabs once again since last coder didn't submitted any PR so far!

@issuehunt-oss

This comment has been minimized.

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jan 27, 2020
@leodrk
Copy link

leodrk commented Jul 2, 2020

Hi, im interested in trying to resolve this issue. I got a question, to make a visual effect for the skill is part of the request?

i`ve never created a pull request via issueHunt, it is imperative to use it?

@DreadKnight
Copy link
Member Author

DreadKnight commented Jul 2, 2020

@leodrk Heya! No visual effect needed, as that's already done. This is about tweaking the ability's own upgrade a little bit.
Regarding IssueHunt, that's only if you want the bounty, as it's a bounty system that you simply register using GitHub itself.
You still create the PR itself on GitHub, as usual. Feel free to go for it :-)

@DreadKnight
Copy link
Member Author

DreadKnight commented Jul 10, 2020

@leodrk Are you still looking into this? If not, it's fine, let me know. One week soft deadline otherwise, meaning it will be up for takes again.

@leodrk
Copy link

leodrk commented Jul 13, 2020

hi sorry for the delay, i will dedicate the next days to this issue and notify you by this chat if I cannot resolve it

@DreadKnight
Copy link
Member Author

@leodrk Understood. I hope that you'll manage :)

@DreadKnight
Copy link
Member Author

Issue up for taking once again. PR's welcome!

@DreadKnight DreadKnight pinned this issue Aug 4, 2020
@DreadKnight DreadKnight added the Hacktoberfest T-shirt https://hacktoberfest.digitalocean.com label Sep 30, 2020
@DreadKnight DreadKnight removed the Hacktoberfest T-shirt https://hacktoberfest.digitalocean.com label Nov 6, 2020
@issuehunt-oss

This comment has been minimized.

@issuehunt-oss

This comment has been minimized.

@issuehunt-oss

This comment has been minimized.

@issuehunt-oss issuehunt-oss bot removed the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jul 8, 2021
@nandastone
Copy link
Contributor

@DreadKnight

Currently the ability is coded to be a regular 3 range inline attack on a single target, doing 10 slash and 10 fire damage. The upgrade extends the range to 5. I don't believe that's how it should work based on its description, or this issue. Can you please clarify exactly how this ability, and its upgrade should work?

  1. "This attack has 2 hexagons extra reach." Does that mean it will also damage anyone up to two hexes beyond the initial target?
  2. "10 slash + 10 burn damage for each hit" Does this mean the initial target and any additional (behind) targets get hit for 10 + 10 each?
  3. "Abolished's Fiery Touch upgrade should be tweaked so that only the burn damage will continue 3 extra hexagons more than the slash damage" Assuming my understanding of question 1 is correct, does this mean we have 2 hexes of slash damage and fire damage behind the initial target, then another 3 hexes of just the fire damage?
  4. Assuming the above is correct, do the extra hexes beyond the initial target stop on the first target? Or are they basically an inline aoe?
  5. Do the extra hexes start from the back of the target creature regardless of size? i.e. a 3 size creature will essentially extend the hexes another two in disance vs a 1 size creature.
  6. Anything else I should know?

@DreadKnight
Copy link
Member Author

@DreadKnight

Currently the ability is coded to be a regular 3 range inline attack on a single target, doing 10 slash and 10 fire damage. The upgrade extends the range to 5. I don't believe that's how it should work based on its description, or this issue. Can you please clarify exactly how this ability, and its upgrade should work?

  1. "This attack has 2 hexagons extra reach." Does that mean it will also damage anyone up to two hexes beyond the initial target?
  2. "10 slash + 10 burn damage for each hit" Does this mean the initial target and any additional (behind) targets get hit for 10 + 10 each?
  3. "Abolished's Fiery Touch upgrade should be tweaked so that only the burn damage will continue 3 extra hexagons more than the slash damage" Assuming my understanding of question 1 is correct, does this mean we have 2 hexes of slash damage and fire damage behind the initial target, then another 3 hexes of just the fire damage?
  4. Assuming the above is correct, do the extra hexes beyond the initial target stop on the first target? Or are they basically an inline aoe?
  5. Do the extra hexes start from the back of the target creature regardless of size? i.e. a 3 size creature will essentially extend the hexes another two in disance vs a 1 size creature.
  6. Anything else I should know?

Idea with this is the following:

  • Abolished has some pretty long hands, being able to reach units further away than other units do with their basic attacks
  • the hand itself does physical damage (the slash), that also ignites itself in the process to deal bonus damage (the burn)
  • it's a single target "melee" attack animation wise that's basically disguised functionality wise as a ranged attack so to say
  • the upgrade causes the flame to go further and only deal that burn damage for slightly out of reach targets (a fireball)

@DreadKnight
Copy link
Member Author

DreadKnight commented Dec 24, 2021

@nandastone So instead of using dashed hexagons (which would add confusion and represent "unavailable" targets usually), we should actually use scaled down lined hexagons instead, which will represent less efficiency or damage, that way we can eventually make them scale percentage wise in order to solve an issue like #326, by differentiating more viable targets overall and showing bigger hexagons under such targets. Nightmare's Icicle Tongue could or Snow Bunny's Chilling Spit could make very good use of it.

I think the 10 slash + 10 burn damage is a bit too low considering this is a lvl 7 unit, we should buff that to 15 slash + 15 burn.

@nandastone
Copy link
Contributor

As discussed in Discord, I'm having trouble understanding exactly how the requested changes should work, as the functionality you're describing sounds quite different to the current ability.

Because this is a very "visual" change, it'd be a huge help if you could visually mock up how the ability should work regarding targeting and activation.

For example, screenshots with annotations demonstrating the new rules in different situations and showing the hex visual states.

@DreadKnight
Copy link
Member Author

@nandastone I've revamped the OP to be more clear and also included mock-up(s). Hopefully the idea is depicted properly now :)

@DreadKnight DreadKnight unpinned this issue Jan 4, 2022
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this issue Apr 20, 2023
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this issue Apr 20, 2023
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this issue Apr 20, 2023
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this issue Apr 20, 2023
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this issue Apr 20, 2023
Abolished "Fiery Touch" ability change + shrunken targeting hexes, fixes FreezingMoon#1088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abilities The issue is related to an unit ability or more coding This issue requires some programming priority This should get fixed as soon as possible!
Projects
Development

No branches or pull requests

5 participants