horizontal game canvas rescale regression

[DreadKnight]

The development version doesn't properly maintain the aspect ratio of the game canvas when making the browser window smaller horizontally, while the stable version works fine. Yet another regression.

dev: https://ancientbeast-beta.herokuapp.com

stable: https://play.ancientbeast.com

[johnnybigoode-zz]

Hey, is anyone working on this? If not, I'd like to try! First Timer here.

[DreadKnight]

Heya! Feel free to go for it. It's one of those bugs that affects a lot of people. Mar, 2 oct. 2018, 03:29 johnnybigoode <notifications@github.com> a scris:

…

Hey, is anyone working on this? If not, I'd like to try! First Timer here. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1444 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAj23w5NBEigaNfyvzMt3bTArZ3QdnkZks5ugrNqgaJpZM4WNS_1> .

[johnnybigoode-zz]

You may find the change here: johnnybigoode-zz@2557632

Hey @DreadKnight ! After fiddling with the I found out that the offender was the bottom margin. After reading about Phaser, it seems that the default values are relevant for the correct rendering. So I managed to fix the issue by changing the default margin-bottom on styles.less:

The margin will still change size, but won't cut the canvas like before.

Is this valid? Maybe you could point me to more Phaser documentation, or some tips on where in the code should I look.

[DreadKnight]

Great job, @johnnybigoode This did the trick, one less regression, woot! 👍