Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go big, don't go home #1730

Closed
DreadKnight opened this issue Aug 9, 2020 · 10 comments
Closed

go big, don't go home #1730

DreadKnight opened this issue Aug 9, 2020 · 10 comments
Assignees
@jamesleeat
Labels
coding This issue requires some programming easy Good place to start if you're a new developer input Deals with hotkeys, interaction & accessibility mobile Specific issues related to any mobile devices visuals Various things that easily catch the eye
Projects
interface tweaks Progressive Web App
Milestone
0.4 - Bounty Hunter

Comments

@DreadKnight
Copy link
Member

DreadKnight commented Aug 9, 2020 •
edited

The Fullscreen button should be displayed instead of the Flee match one, less UI overlap for mobile phones when in portrait mode.
@DreadKnight DreadKnight added coding This issue requires some programming visuals Various things that easily catch the eye easy Good place to start if you're a new developer labels Aug 9, 2020
@DreadKnight DreadKnight added this to the 0.4 - Bounty Hunter milestone Aug 9, 2020
@DreadKnight DreadKnight added this to To Do in Progressive Web App via automation Aug 9, 2020
@DreadKnight DreadKnight added this to generic stuff in interface tweaks Aug 9, 2020
@DreadKnight DreadKnight mentioned this issue Aug 9, 2020
Open
@DreadKnight DreadKnight added the input Deals with hotkeys, interaction & accessibility label Aug 11, 2020
@DreadKnight DreadKnight changed the title F is for fullscreen go big, don't go home Aug 11, 2020
@DreadKnight DreadKnight added the mobile Specific issues related to any mobile devices label Aug 11, 2020
@DreadKnight
Copy link
Member Author

DreadKnight commented Aug 11, 2020 •
edited

This is during matches, not in the pre-match screen etc. (but will move around the fullscreen button from that screen as well soon).

@DreadKnight DreadKnight mentioned this issue Aug 18, 2020
Closed
@DreadKnight DreadKnight added the Hacktoberfest T-shirt https://hacktoberfest.digitalocean.com label Sep 30, 2020
@elsazuckerman
Copy link

Hi,
I'd like to give this a try.
It'll be my first ever open source contribution.

@DreadKnight
Copy link
Member Author

DreadKnight commented Oct 1, 2020 •
edited

@elsazuckerman Happy Hacktober! I've assigned you to this issue, good luck!
Always nice to see coders popping their cherry so to speak with this project. 🍒

@elsazuckerman
Copy link

Just wondering, should the flee button be displayed somewhere else instead, or are we just getting rid of it?

@DreadKnight
Copy link
Member Author

@elsazuckerman Good that you reminded me. It should probably be moved to the score screen (activated by the upper right corner icon) while the game is not finished. Could become a different type of button or retain shape and even be placed in a corner.

@DreadKnight
Copy link
Member Author

DreadKnight commented Oct 2, 2020 •
edited

There's the previously mentioned around issue #1746 exactly about that it seems; I forgot about it last night as I was in rush / tired.

@DreadKnight
Copy link
Member Author

@elsazuckerman Hey, any progress with this? Otherwise will let someone else take a poke at it.

@DreadKnight
Copy link
Member Author

Issue long overdue, so it's once again up for taking. If anyone interested, leave a comment.

@DreadKnight DreadKnight removed the Hacktoberfest T-shirt https://hacktoberfest.digitalocean.com label Nov 6, 2020
@jamesleeat
Copy link
Contributor

Has this been solved? I would like to work on it.

@DreadKnight
Copy link
Member Author

DreadKnight commented Nov 22, 2020 via email

@jamesleeat jamesleeat mentioned this issue Nov 22, 2020
Merged
Progressive Web App automation moved this from To Do to Done Nov 23, 2020
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this issue Apr 20, 2023
@DreadKnight
Merge pull request FreezingMoon#1820 from jamesleeat/1730
13ae0a9 
Replaced flee for fullscreen button in match UI, closes FreezingMoon#1730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesleeat jamesleeat

Labels
coding This issue requires some programming easy Good place to start if you're a new developer input Deals with hotkeys, interaction & accessibility mobile Specific issues related to any mobile devices visuals Various things that easily catch the eye
Projects
Progressive Web App
  
Done
interface tweaks
generic stuff
Milestone
0.4 - Bounty Hunter
Development

No branches or pull requests
3 participants
@DreadKnight @jamesleeat @elsazuckerman