Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remember viewed unit #851

Closed
DreadKnight opened this issue Feb 18, 2016 · 8 comments
Closed

remember viewed unit #851

DreadKnight opened this issue Feb 18, 2016 · 8 comments
Labels
coding This issue requires some programming easy Good place to start if you're a new developer priority This should get fixed as soon as possible!

Comments

@DreadKnight
Copy link
Member

DreadKnight commented Feb 18, 2016

The last selected/viewed unit should be remembered for each player tab. This is useful for when wanting to materialize a unit and then canceling in order to move Dark Priest to a better location in order to try again.

Clicking an avatar or right clicking a unit should keep their current behavior, focusing on that specific unit.

@DreadKnight DreadKnight added coding This issue requires some programming priority This should get fixed as soon as possible! labels Feb 18, 2016
@DreadKnight DreadKnight added this to the 0.3 - Bouncer milestone Mar 8, 2016
@DreadKnight DreadKnight assigned slugo and unassigned Spencer-Zhang May 31, 2016
@DreadKnight DreadKnight added this to unit dash in interface tweaks Mar 29, 2017
@DreadKnight DreadKnight added the easy Good place to start if you're a new developer label Apr 2, 2017
@DreadKnight
Copy link
Member Author

Related to this issue #1147

@c3ho
Copy link
Contributor

c3ho commented Oct 3, 2019

Hi, can I try working on this issue?

@DreadKnight
Copy link
Member Author

@c3ho Sure thing, give it a go!

@c3ho
Copy link
Contributor

c3ho commented Oct 7, 2019

I have a question, did you want to remember the last unit viewed until it was successfully materialized and then randomize it again?

@DreadKnight
Copy link
Member Author

DreadKnight commented Oct 7, 2019

@c3ho Well, the materialization ability, Godlet Printer and most others only work once pet turn, so as far as I can tell, there's no need for that :)

@DreadKnight DreadKnight unpinned this issue Oct 8, 2019
@c3ho
Copy link
Contributor

c3ho commented Oct 10, 2019

I've figured out more or less what changes I need to make to remember viewed units. However, I'm running into an issue right now, because I don't have a global variable to memorize/keep track of the creatureType, everytime I call showCreature (by pressing r or the godlet printer) it will randomize. Do you have any suggestions?

@DreadKnight
Copy link
Member Author

@c3ho I don't really see the issue... you have your answer right there I guess, just like you got access to the source code and you can edit it, so make a variable if you have to! xD

@c3ho c3ho mentioned this issue Oct 10, 2019
@DreadKnight
Copy link
Member Author

Seems this is not working anymore, regression that needs to be fixed.

@DreadKnight DreadKnight reopened this Dec 30, 2021
@DreadKnight DreadKnight pinned this issue Dec 30, 2021
@DreadKnight DreadKnight unpinned this issue Jan 1, 2022
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this issue Apr 20, 2023
remember last viewed unit for materialization, fixes FreezingMoon#851
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this issue Apr 20, 2023
…d-unit

regression fix for showing last selected unit, closes FreezingMoon#851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coding This issue requires some programming easy Good place to start if you're a new developer priority This should get fixed as soon as possible!
Projects
Development

No branches or pull requests

5 participants