Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed disturbing shout issue #1445 #1447

Closed
wants to merge 3 commits into from
Closed

Conversation

Todai88
Copy link

@Todai88 Todai88 commented Oct 5, 2018

Added reference to disturbing shout asset for the ability.
(issue #1445)

@DreadKnight DreadKnight temporarily deployed to ancientbeast-pr-1447 October 6, 2018 09:20 Inactive
@DreadKnight
Copy link
Member

Hey @Todai88 ! I've tested your PR. The sprite works pretty nicely, but there are some issues:

  • the ability does no damage
  • game freezes overall after ability has been used and it's about to get upgraded, because you deleted the proper ability upgrade code and copied the one from Snow Bunny instead apparently
  • when used from the other side (blue/right attacking red/left), the projectile travels towards the end of the target (last hexagon)

I've added a save that makes it a bit easier to test changes out:

AB.restoreGame("AB-0.3:eyJjb25maWciOnsicGxheWVyTW9kZSI6MiwiY3JlYUxpbWl0TmJyIjozLCJ1bml0RHJvcHMiOjEsImFiaWxpdHlVcGdyYWRlcyI6MywicGxhc21hX2Ftb3VudCI6MzAsInR1cm5UaW1lUG9vbCI6LTEsInRpbWVQb29sIjotNjAsImJhY2tncm91bmRfaW1hZ2UiOiJEcmFnb24gU2t1bGwifSwibG9nIjpbeyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJoZXgiLCJ4IjoyLCJ5Ijo1fSwiaWQiOjMsImFyZ3MiOnsiMSI6eyJjcmVhdHVyZSI6IlA2IiwiY29zdCI6OX19fSx7ImFjdGlvbiI6InNraXAifSx7ImFjdGlvbiI6ImFiaWxpdHkiLCJ0YXJnZXQiOnsidHlwZSI6ImhleCIsIngiOjE1LCJ5Ijo1fSwiaWQiOjMsImFyZ3MiOnsiMSI6eyJjcmVhdHVyZSI6IlA2IiwiY29zdCI6OX19fSx7ImFjdGlvbiI6InNraXAifSx7ImFjdGlvbiI6InNraXAifSx7ImFjdGlvbiI6InNraXAifV19")

@DreadKnight DreadKnight temporarily deployed to ancientbeast-pr-1447 October 6, 2018 11:40 Inactive
@Todai88
Copy link
Author

Todai88 commented Oct 6, 2018

Sorry, first time actually helping out with a public repo. Can you see if the push to my fork actually is part of this PR?

@DreadKnight
Copy link
Member

DreadKnight commented Oct 6, 2018

Understood, no worries, I'm always happy to get contributions to the project. There are still some issues:

  • shooting from right to left still has the projectile go too much versus medium/large units
  • when an unit bypasses an enemy one, it should actually turn around when hitting behind
  • the upgraded ability freezes the game when killing unit (projectile supposed to also continue), see log

"AB-0.3:eyJjb25maWciOnsicGxheWVyTW9kZSI6MiwiY3JlYUxpbWl0TmJyIjozLCJ1bml0RHJvcHMiOjEsImFiaWxpdHlVcGdyYWRlcyI6MywicGxhc21hX2Ftb3VudCI6MzAsInR1cm5UaW1lUG9vbCI6LTEsInRpbWVQb29sIjotNjAsImJhY2tncm91bmRfaW1hZ2UiOiJEYXJrIEZvcmVzdCJ9LCJsb2ciOlt7ImFjdGlvbiI6ImFiaWxpdHkiLCJ0YXJnZXQiOnsidHlwZSI6ImhleCIsIngiOjMsInkiOjR9LCJpZCI6MywiYXJncyI6eyIxIjp7ImNyZWF0dXJlIjoiUzEiLCJjb3N0IjoyfX19LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoiYWJpbGl0eSIsInRhcmdldCI6eyJ0eXBlIjoiaGV4IiwieCI6MTMsInkiOjR9LCJpZCI6MywiYXJncyI6eyIxIjp7ImNyZWF0dXJlIjoiUDYiLCJjb3N0Ijo5fX19LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoiYWJpbGl0eSIsInRhcmdldCI6eyJ0eXBlIjoiYXJyYXkiLCJhcnJheSI6W3sieCI6MTAsInkiOjR9LHsieCI6OSwieSI6NH0seyJ4Ijo4LCJ5Ijo0fSx7IngiOjcsInkiOjR9LHsieCI6NiwieSI6NH0seyJ4Ijo1LCJ5Ijo0fSx7IngiOjQsInkiOjR9LHsieCI6MywieSI6NH1dfSwiaWQiOjIsImFyZ3MiOnsiMSI6eyJkaXJlY3Rpb24iOjQsImhleCI6eyJ4IjozLCJ5Ijo0fSwiY2hvaWNlSW5kZXgiOjB9fX0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJhcnJheSIsImFycmF5IjpbeyJ4IjoxMCwieSI6NH0seyJ4Ijo5LCJ5Ijo0fSx7IngiOjgsInkiOjR9LHsieCI6NywieSI6NH0seyJ4Ijo2LCJ5Ijo0fSx7IngiOjUsInkiOjR9LHsieCI6NCwieSI6NH0seyJ4IjozLCJ5Ijo0fV19LCJpZCI6MiwiYXJncyI6eyIxIjp7ImRpcmVjdGlvbiI6NCwiaGV4Ijp7IngiOjMsInkiOjR9LCJjaG9pY2VJbmRleCI6MH19fSx7ImFjdGlvbiI6InNraXAifSx7ImFjdGlvbiI6InNraXAifSx7ImFjdGlvbiI6InNraXAifSx7ImFjdGlvbiI6InNraXAifV19"

@Todai88
Copy link
Author

Todai88 commented Oct 6, 2018

OK, cool. Will have a look at that. How do I go about using the log?

@DreadKnight
Copy link
Member

@Todai88 Ctrl+Shift+J and paste that in. You would need to be in the pre-match screen.
https://github.com/FreezingMoon/AncientBeast/blob/master/docs/CONTRIBUTING.md#report-issues

@DreadKnight
Copy link
Member

@Todai88 Hey! Any progress with this by any chance? Otherwise will merge as it is in a couple of days and open new issues for the remaining stuff.

@DreadKnight
Copy link
Member

@Todai88 Let me know if you can finish this. It would be a shame for all that work to go to waste...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants