Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hover on touch devices #1526

Merged
merged 2 commits into from May 15, 2019
Merged

Fix hover on touch devices #1526

merged 2 commits into from May 15, 2019

Conversation

TheSeally
Copy link
Contributor

Fix #1506

  1. Add hover class
  • change implementation of hovering button from CSS hover to hover class
  • add new property to Button class constructor which shows is shortcut needed
  • add default behaviour for buttons with shortcuts
  1. Add touch functionality
  • add touchstart and touchend function;
  • when player touch button and after it move finger more than 50px click event doesn't happen

* change implementation of hovering button from CSS hover to hover class
* add new property to Button class constructor which shows is shortcut needed
* add default behaviour for buttons with shortcuts
* add `touchstart` and `touchend` function;
* if player touch button and after it move finger more than 50px `click` event doesn't happen
@DreadKnight
Copy link
Member

@TheSeally Great job, this really makes the difference!
Only one thing could improve this imo, but I've opened a different issue for it #1527

@DreadKnight DreadKnight merged commit 2c1f3ea into FreezingMoon:master May 15, 2019
@TheSeally
Copy link
Contributor Author

Thank you for the opportunity to participate in opensource project. I'm glad to help your project.
I try to take issue #1527 later

@DreadKnight
Copy link
Member

Cool, if you can manage that issue as well, awesome! Otherwise there are plenty of other open issues that I greatly struggle with as a crappy coder that I am :D

CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bad tooltip display
2 participants