New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for toggle regression #1666
Conversation
@rianconley Did a bit of testing and found one problem so far: when scrolling into one of the directions or pressing the passive icon, the "Canceled" state is not triggered (having no ability selected, allowing for unit movement), but if scrolling in the other direction, it works just as intended. |
hey @DreadKnight , can you elaborate on the expected scroll behavior? Is it when you use the mouse wheel which cycles through the abilities? Can you explain how the canceled should work if you press passive or "scroll"? Thanks. |
@rianconley After going through all the usable abilities once, the "Canceled" state should be triggered, resulting in no usable ability selected, being able to just move the unit around. |
Hey @DreadKnight , please pull the latest from AB-1634 pull request. The update addresses canceling ability after cycling.. |
@rianconley I've tested it, seems to work fine this time, well done! |
fix for toggle regression, closes FreezingMoon#1634
If your pull request tries to address a specific issue from the repository, please reference to it.
Don't forget to include a description of the changes proposes. https://discord.me/AncientBeast
Hey @DreadKnight , here's the pull request for the issue #1634. Let me know if there's any regression issues.
IssueHunt Summary
Referenced issues
This pull request has been submitted to: