Set fullScreenScaleMode #1709
Merged
Set fullScreenScaleMode #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm not sure why those checks are failing. Any ideas? |
|
I also noticed there is a duplicate issue for this. #1702 |
|
@Vorlent Well done, was aware some Phaser thingy was missing that was dealing with this 👍 I've tested it and works well. Regarding that other PR, if you mean the pre-match screen UI, feel free to make new PR. If it's related to the in-game HUD, then feel free to take a swing at issue #1505 Don't forget to 🌟 the project and hope to see more PR's from you :-) |
CyberBishop
pushed a commit
to CyberBishop/AncientBeast
that referenced
this pull request
Apr 20, 2023
Set fullScreenScaleMode so that game is playable on mobiles in fullscreen, fixes FreezingMoon#673 FreezingMoon#1702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #673
Fullscreen uses a different scaling mode by default (ScaleManager.NONE).
scaleMode and fullScreenScaleMode are now identical and the same scaling is now being used in both outside and inside fullscreen mode.
I have also added some minor UI cleanup that makes the launch UI slightly more usable on smartphones.
If you want I can upload those changes in a different PR.
IssueHunt Summary
Referenced issues
This pull request has been submitted to: