Fixed Issue 633, Slight refactor in hexgrid to remove duplicate code #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@CKillen Well done! Reusing code is always nice. And regarding Shift key, that would be nice as well now that you mentioned it. Feel free to make new PR for that, will make new issue real quick. |
CyberBishop
pushed a commit
to CyberBishop/AncientBeast
that referenced
this pull request
Apr 20, 2023
Show active unit range when hovering marker + code reuse, fixes FreezingMoon#633
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#633
When hovering over roundmarker the current units movement range changes to grey so it can be seen.
I also refactored hexgrid.js to remove duplicate code between showMovementRange and my newly created showMovementRangeInOverlay.
Possible issues - this doesn't grey out the hexes when pressing the shift button. Since that wasn't listed in the issue I wasn't sure if I should add it.