-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: hexes should accurately respond to pointer x, y #2253 #2399
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@andretchen0 Unlike HoMM3, we squished the hexagons a bit so that they seem in perspective in order to enhance that. |
@andretchen0 Tested, while not pixel perfect, still a huge improvement and it also fixes a very weird issue apparently: |
Thanks for testing. Will have a look tomorrow. |
@andretchen0 Ok, will merge as it is right away; you fixed that stuff I made the gif for, so no worries about it 👍🏻 |
Hold on. Is the issue in the gif you posted the "weird issue [that was fixed]" that you were talking about? Or is it still an issue with this PR? I can't reproduce anyway. Edit: nevermind. We're both posting. I just saw your response. ;) |
That was something I discovered in the beta before merging that I wasn't fully aware of; opened new issue just to close it with this PR as well, for the sake of issue history. All good. |
This fixes #2253.
hitArea points were producing a polygon of the wrong size.
The code's a bit hacky, as the width/height dimensions in
Hex
are converted to polygon points using some "magic" numbers.