Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 15 and 16 #17

Merged
merged 3 commits into from
Dec 3, 2021

Conversation

dploeger
Copy link
Contributor

Sorry for not disecting the changes here, but I started with a fix for #16, then #15 and finally noticed, that the whitespace format for the file was mixed so I converted it all to spaces.

So this includes configuring the ImageMagick binary path (which I needed on macOS) #15, the support for stereoscopy/multiviews #16.

…ded configuration of binary path. Added support for multiviews

fixes FreezingMoon#15
fixes FreezingMoon#16
@DreadKnight
Copy link
Member

Thanks for the PR.

Anyone around with a mac to test this out? Otherwise I'll merge eventually after a test on linux (just in case).

@dploeger
Copy link
Contributor Author

I added another commit that fixes #18 as well.

@dploeger
Copy link
Contributor Author

dploeger commented Dec 3, 2021

And it fixes #19 now as well.

@DreadKnight care to merge? ;-)

@DreadKnight
Copy link
Member

Skimmed the code, will merge untested as I've been out of blender for a minute, really need to get back in soon.
Will probably convert it all to tabs, but in a different commit, as it will fully make this one muddy if doing so atm.

@DreadKnight DreadKnight merged commit 9d724b8 into FreezingMoon:master Dec 3, 2021
@dploeger
Copy link
Contributor Author

dploeger commented Dec 3, 2021

Awesome, thanks.

@DreadKnight
Copy link
Member

@dploeger Thanks again for your contributions :-) Can't wait to make good use of this add-on myself.

@dploeger
Copy link
Contributor Author

dploeger commented Dec 3, 2021

yw. I'm already using it heavily for this game: https://gitlab.com/d1314/safehouse/safehouse-design :)

@DreadKnight
Copy link
Member

@dploeger Hmm, interesting. Looking forward to some screenies or anything visual xD

@dploeger
Copy link
Contributor Author

dploeger commented Dec 3, 2021

@DreadKnight Oh, I tweet about it from time to time using the account https://twitter.com/deepentertains

Here's an example of the first room of the game: https://twitter.com/deepentertains/status/1425828793919234070?s=20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants