Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded copies of "node_modules" #4

Closed
sumpfralle opened this issue Dec 7, 2018 · 2 comments
Closed

Embedded copies of "node_modules" #4

sumpfralle opened this issue Dec 7, 2018 · 2 comments

Comments

@sumpfralle
Copy link
Contributor

003_applicationPhonegap/node_modules seems to be a directory that is created and maintained as a part of the build process. Thus it should not be part of the repository.
@stefan-walluhn
Copy link

Same for plugins folder as well as tons of custom editor / ide configs spread all over the code base, that should never be part of a git repository.

Please adjust your build pipeline and the developers gitignore as described in:
https://gist.github.com/subfuzion/db7f57fff2fb6998a16c

@oputdeveloper
Copy link
Contributor

the node modules are now removed and I adapted the Git Ignore. I close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sumpfralle @stefan-walluhn @oputdeveloper