Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] meshviewer-ffrgb export empty array #152

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Conversation

genofire
Copy link
Member

@genofire genofire commented Jan 14, 2019

  • Export a nil / null produced an error at meshviewer-ffrgb

Todo

  • create test for nil values

@genofire genofire added the wip label Jan 14, 2019
@codecov-io
Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #152 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   73.89%   73.92%   +0.03%     
==========================================
  Files          47       47              
  Lines        1601     1603       +2     
==========================================
+ Hits         1183     1185       +2     
  Misses        386      386              
  Partials       32       32
Impacted Files Coverage Δ
output/meshviewer-ffrgb/struct.go 81.25% <100%> (+0.6%) ⬆️

@genofire genofire removed the wip label Jan 15, 2019
@genofire genofire merged commit f5d0067 into master Jan 15, 2019
@genofire genofire deleted the null-address branch January 15, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants