Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] add output prometheus-sd (service discovery) #213

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conversation

genofire
Copy link
Member

@genofire genofire commented Apr 13, 2022

Description

make smaller PR of #189 to easier merge.

Motivation and Context

create a json for prometheus service discovery e.g. for usage in ping blackbox-exporter

Checklist:

  • My code follows the code style of this project.
  • I have added also tests for my new code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@genofire genofire force-pushed the prom-sd branch 4 times, most recently from 5323794 to 62d708b Compare April 13, 2022 23:54
@genofire genofire changed the title add output prometheus-sd (service discovery) [TASK] add output prometheus-sd (service discovery) Apr 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #213 (fbbb1d4) into main (64b9cfe) will increase coverage by 0.65%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   73.96%   74.61%   +0.64%     
==========================================
  Files          54       55       +1     
  Lines        2297     2344      +47     
==========================================
+ Hits         1699     1749      +50     
+ Misses        555      553       -2     
+ Partials       43       42       -1     
Impacted Files Coverage Δ
output/prometheus-sd/output.go 100.00% <100.00%> (ø)
output/meshviewer-ffrgb/meshviewer.go 87.87% <0.00%> (+3.03%) ⬆️

@genofire genofire force-pushed the prom-sd branch 8 times, most recently from f1d6520 to 196903b Compare April 14, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants