[BUGFIX] mutex like it should be #34
Conversation
models/graph.go
Outdated
| builder.readNodes(nodes.List) | ||
| nodes.RUnlock() |
There was a problem hiding this comment.
Mach bessser builder.readNodes(nodes) und verschiebe die Locks in die Funktion.
models/graph.go
Outdated
| @@ -48,7 +48,9 @@ func (nodes *Nodes) BuildGraph() *Graph { | |||
| vpn: make(map[string]interface{}), | |||
| } | |||
|
|
|||
| nodes.RLock() | |||
There was a problem hiding this comment.
Und das kann nicht mehr zu einem Deadlock führen?
There was a problem hiding this comment.
Ich hab keine Ahnung, wo der deadlock herkommt - doch dies soll mit diesen PR mit in Erfahrung gebracht werden.
Einmal alles untersuchen, was wo sich sperrt und ob es so richtig ist.
There was a problem hiding this comment.
Vielleicht hiermit testen? https://github.com/sasha-s/go-deadlock
There was a problem hiding this comment.
Hört sich interessant an :)
genofire
force-pushed
the
improve-mutex
branch
4 times, most recently
from
11efd72
to
5b587d5
Compare
|
I don't think this should be merged into master. |
|
greate, i will create a VM with a complete testing stack - for problemes like this. |
|
You can also use the productive system as long as you monitor it and act in case of errors. |
genofire
force-pushed
the
improve-mutex
branch
2 times, most recently
from
4f0d783
to
880e1bc
Compare
corny
force-pushed
the
master
branch
2 times, most recently
from
108eb91
to
8b8b144
Compare
|
Liegt zu lange rum -> close. |
No description provided.