Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] division by zero #41

Closed
wants to merge 3 commits into from
Closed

[BUGFIX] division by zero #41

wants to merge 3 commits into from

Conversation

genofire
Copy link
Member

No description provided.

@genofire genofire mentioned this pull request Mar 14, 2017
Merged
corny
corny requested changes Mar 14, 2017
View reviewed changes
Copy link
Member

@corny corny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no memory, the usage has to be empty (nil, not zero!).

@genofire
Copy link
Member Author

the datatype uint32 could not have the value nil -> we could declare it as ref *uint32

@genofire genofire added review and removed wip labels Mar 14, 2017
@genofire
Copy link
Member Author

genofire commented Mar 14, 2017 •
edited
Loading

Or should me make every json:omitempty to referenze ?

@corny
Copy link
Member

corny commented Mar 14, 2017

That depends. Storing 0 when there is no value is generally not a good idea.

@genofire
Copy link
Member Author

okay, so we should equalize the json:omitempty and the references together!

@genofire genofire force-pushed the memory-calc branch 2 times, most recently from 843ca24 to 2d90ae3 Compare March 15, 2017 22:37
corny
corny reviewed Mar 16, 2017
View reviewed changes
meshviewer/meshviewer.go Outdated

return &Statistics{
meshviewerStats := &Statistics{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte in statistics oder result umbenennen.

@genofire genofire force-pushed the memory-calc branch 2 times, most recently from 94e0ee2 to 3dba58e Compare March 21, 2017 14:59
@genofire genofire self-assigned this Mar 29, 2017
@genofire genofire force-pushed the memory-calc branch 3 times, most recently from 83fd4ec to 13c232e Compare April 10, 2017 17:51
@corny corny changed the title [BUGFIX] divide by zero [BUGFIX] division by zero Apr 10, 2017
@corny corny force-pushed the master branch 2 times, most recently from 108eb91 to 8b8b144 Compare April 18, 2017 00:42
@genofire genofire removed the bug label Apr 19, 2017
@coveralls
Copy link

coveralls commented May 22, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.8%) to 55.709% when pulling 031efd6 on memory-calc into dc24c8b on master.

@corny corny closed this in 8a8d9a4 Jul 6, 2017
corny added a commit that referenced this pull request Jul 6, 2017
@corny
Fix division by zero to calculate memory usage
2148a7d 
Closes #41
@genofire genofire deleted the memory-calc branch October 1, 2017 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corny corny corny requested changes

Assignees

@genofire genofire

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@genofire @corny @coveralls