[TASK] add support for babel networks #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corny
requested changes
Jun 29, 2017
There was a problem hiding this comment.
Bitte entferne das Send aus ifaceSendUnicast und ifaceSendMulticast. Ich denke außerdem, dass wir uns auf insgesamt zwei Einstellungen beschränken können:
interfacefür Multicast (und Unicast, wenn nicht gesetzt)interface_unicastfür Unicast-Nachrichten. Wenn nicht gesetzt, wirdinterfaceverwendet.
|
Wie sollen die Antworten auf die Unicast-Pakete ankommen, wenn du dafür keinen Socket öffnest? Ist mir unklar ... noch nicht getestet? |
corny
requested changes
Jun 29, 2017
| @@ -74,7 +80,7 @@ func main() { | |||
| time.Sleep(delay) | |||
| } | |||
|
|
|||
| collector = respond.NewCollector(connections, nodes, config.Respondd.Interface, config.Respondd.Port) | |||
| collector = respond.NewCollector(connections, nodes, config.Respondd.InterfaceListen, config.Respondd.InterfaceSendMulticast, config.Respondd.InterfaceSendUnicast, config.Respondd.Port) | |||
There was a problem hiding this comment.
Wenn das drei unterschiedliche interfaces sind, geht gar nichts mehr? Bitte mal drüber nachdenken.
genofire
changed the title
corny
changed the title
|
Ist der PR noch aktuell? Wenn ja, bitte auf den |
|
Hab gerade versucht zu rebasen - keine Lust mehr ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#70 should fix