Skip to content

Commit

Permalink
Default favicon served with HTTP code 200
Browse files Browse the repository at this point in the history
Fix #760
  • Loading branch information
marienfressinaud committed Jan 26, 2015
1 parent 39b8c75 commit da7d34d
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion p/f.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ function download_favicon($website, $dest) {
function show_default_favicon() {
global $default_favicon;

header('HTTP/1.1 404 Not Found');
header('Content-Type: image/ico');
readfile($default_favicon);
die();

This comment has been minimized.

Copy link
@Alkarex

Alkarex Jan 26, 2015

Member

Remember to serve HTTP cache information as well. See a bit below in the same file for an example with httpConditional()

This comment has been minimized.

Copy link
@marienfressinaud

marienfressinaud Jan 26, 2015

Author Member

Done f5043db

Expand Down

0 comments on commit da7d34d

Please sign in to comment.