Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreshRSS_EntryDAOSQLite declaration not compatible with FreshRSS_EntryDAO #1220

Closed
marienfressinaud opened this issue Aug 19, 2016 · 4 comments
Closed

FreshRSS_EntryDAOSQLite declaration not compatible with FreshRSS_EntryDAO #1220

marienfressinaud opened this issue Aug 19, 2016 · 4 comments
Assignees
@Alkarex
Labels
Important 🔥
Milestone
1.5.0

Comments

@marienfressinaud
Copy link
Member

After an update to the last dev version, I have these warnings:

Strict Standards: Declaration of FreshRSS_EntryDAOSQLite::markReadEntries() should be compatible with FreshRSS_EntryDAO::markReadEntries($idMax = 0, $onlyFavorites = false, $priorityMin = 0, $filter = NULL, $state = 0) in /[...]/app/Models/EntryDAOSQLite.php on line 3

Strict Standards: Declaration of FreshRSS_EntryDAOSQLite::markReadCat() should be compatible with FreshRSS_EntryDAO::markReadCat($id, $idMax = 0, $filter = NULL, $state = 0) in /[...]/app/Models/EntryDAOSQLite.php on line 3
@marienfressinaud
Copy link
Member Author

I think it is important to fix before #1219

@Alkarex Alkarex added this to the 1.5.1-beta milestone Aug 19, 2016
Alkarex added a commit to Alkarex/FreshRSS that referenced this issue Aug 19, 2016
@Alkarex
SQLite fix for mark search as read
6afa36e 
FreshRSS#1220
FreshRSS#1218
FreshRSS#608
@Alkarex Alkarex mentioned this issue Aug 19, 2016
Merged
@Alkarex
Copy link
Member

Alkarex commented Aug 19, 2016

Damn, I forgot SQLite for this feature. Should be fixed in #1221 (not tested yet)

@Alkarex
Copy link
Member

Alkarex commented Aug 19, 2016

Should be fixed. Please try again :-)

@Alkarex Alkarex closed this as completed Aug 19, 2016
@Alkarex Alkarex self-assigned this Aug 19, 2016
@marienfressinaud
Copy link
Member Author

Better 👍 :)

javerous pushed a commit to javerous/FreshRSS that referenced this issue Jan 20, 2020
@Alkarex
SQLite fix for mark search as read
69c3719 
FreshRSS#1220
FreshRSS#1218
FreshRSS#608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alkarex Alkarex

Labels
Important 🔥
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@Alkarex @marienfressinaud