Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm before mark as read: Impossible to mark as read #1348

Closed
lapineige opened this issue Oct 31, 2016 · 3 comments
Closed

Confirm before mark as read: Impossible to mark as read #1348

lapineige opened this issue Oct 31, 2016 · 3 comments
Assignees
@Alkarex
Labels
UI 🎨 User Interfaces
Milestone
1.6.2

Comments

@lapineige
Copy link

This is the following of bug #1342.

@Alkarex you added the option disabled in order to prevent users to activate the mark as read feature before the script is loaded.
In my case, the option never disappears.

I'm wondering if the script is correctly loaded/launched.

Is it still an issue of caching, as I have (see #1342) ?
(the main.js script is cached, and removing the cache change nothing)

Thanks in advance for your help :)
@Alkarex Alkarex added this to the 1.7.0 milestone Oct 31, 2016
@Alkarex Alkarex added the UI 🎨 User Interfaces label Oct 31, 2016
@Alkarex Alkarex changed the title [Bug] Impossible to mark as read - script not loaded / not launched ? YunoHost: Impossible to mark as read - script not loaded / not launched Nov 15, 2016
Alkarex added a commit to Alkarex/FreshRSS that referenced this issue Nov 15, 2016
@Alkarex
init confirm after DOM load
8e68ee5 
FreshRSS#1348
@Alkarex Alkarex mentioned this issue Nov 15, 2016
Merged
@Alkarex
Copy link
Member

Alkarex commented Nov 15, 2016

@lapineige Could you please try this patch? #1374

Another observation: it looks like YunoHost is injecting a script ynhpanel.js in <head>, which is not compatible with CSP:

ynhpanel.js:173 Content Security Policy: Les paramètres de la page ont empêché le chargement d’une ressource à self (« default-src https://yunohost.example.net »).

@Alkarex Alkarex changed the title YunoHost: Impossible to mark as read - script not loaded / not launched Confirm before mark as read: Impossible to mark as read Nov 15, 2016
@lapineige
Copy link
Author

lapineige commented Nov 16, 2016 •
edited
Loading

@lapineige Could you please try this patch? #1374

I will do it ASAP, thanks :)

Another observation: it looks like YunoHost is injecting a script ynhpanel.js in , which is not compatible with CSP:

I know, I didn't take any time to change it, because it's the button to go back to yunohost main screen, I don't need it - it's even a bit annoying (taking a lot of space on phones), so I just don't mind ^^

@lapineige
Copy link
Author

Ok, patch working, thank you :)

@Alkarex Alkarex self-assigned this Nov 16, 2016
@Alkarex Alkarex modified the milestones: 1.7.0, 1.6.2 Dec 21, 2016
@Alkarex Alkarex mentioned this issue Feb 23, 2017
Closed
Alkarex added a commit to Alkarex/FreshRSS that referenced this issue Feb 23, 2017
@Alkarex
Un-disable mark-as-read button
bade066 
FreshRSS#1421
FreshRSS#1348
@Alkarex Alkarex mentioned this issue Feb 23, 2017
Merged
javerous pushed a commit to javerous/FreshRSS that referenced this issue Jan 20, 2020
@Alkarex
init confirm after DOM load
66fd375 
FreshRSS#1348
javerous pushed a commit to javerous/FreshRSS that referenced this issue Jan 20, 2020
@Alkarex
Un-disable mark-as-read button
17dc45e 
FreshRSS#1421
FreshRSS#1348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alkarex Alkarex

Labels
UI 🎨 User Interfaces
Projects
None yet
Milestone
1.6.2
Development

No branches or pull requests
2 participants
@Alkarex @lapineige