-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: "Add to favourites" on Reading View #1545
Comments
Related to #1400 |
Thanks @Aasemoon |
@Alkarex Great! Thanks! =) |
I've got the inspiration from the mark as read action. So I've used the id of the feed to trigger the action and not the url in the link. This way, it works all the time. It works in reading mode, it works in normal mode when icon are not displayed. See FreshRSS#1545
@Aasemoon Could you check the PR I've just made and tell me if it suits your needs? |
Hi @aledeg, hmmm I'm not sure exactly what I'm missing, but when I apply the suggested changes to my main.js, I don't see anything different in the reading view. Is that the only file you have changed? |
There is nothing different in the view. But you can use the shortcut available in the normal view. I was wondering if that change is enough for you or if we need to go a bit further. Thank you |
@aledeg , aha, then I guess not. I'd like an "add to favourite" button on the reading view mainly because usually I view my feeds on various tablets. Keyboard shortcuts I've basically never used. |
Thank you for your feedback. I'll try to add something in the view. I am not very comfortable with front-end but I'll give it a try. |
@aledeg Thanks a lot! That would be great. =) |
I've got the inspiration from the mark as read action. So I've used the id of the feed to trigger the action and not the url in the link. This way, it works all the time. It works in reading mode, it works in normal mode when icon are not displayed. See FreshRSS#1545
I've got the inspiration from the mark as read action. So I've used the id of the feed to trigger the action and not the url in the link. This way, it works all the time. It works in reading mode, it works in normal mode when icon are not displayed. See FreshRSS#1545
I've got the inspiration from the mark as read action. So I've used the id of the feed to trigger the action and not the url in the link. This way, it works all the time. It works in reading mode, it works in normal mode when icon are not displayed. See FreshRSS#1545
I've got the inspiration from the mark as read action. So I've used the id of the feed to trigger the action and not the url in the link. This way, it works all the time. It works in reading mode, it works in normal mode when icon are not displayed. See #1545
@Aasemoon The PR is merged. Does it covers what you had in mind? |
I've got the inspiration from the mark as read action. So I've used the id of the feed to trigger the action and not the url in the link. This way, it works all the time. It works in reading mode, it works in normal mode when icon are not displayed. See FreshRSS#1545
I've got the inspiration from the mark as read action. So I've used the id of the feed to trigger the action and not the url in the link. This way, it works all the time. It works in reading mode, it works in normal mode when icon are not displayed. See FreshRSS#1545
Hi there,
I have a request for a tiny adjustment. Could you possibly make it so that the "add to favourites" star button shows up for each item on the reading view as well? Would be very helpful I believe.
Cheers!
The text was updated successfully, but these errors were encountered: