Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: "Add to favourites" on Reading View #1545

Closed
Aasemoon opened this issue May 25, 2017 · 10 comments
Closed

Feature Request: "Add to favourites" on Reading View #1545

Aasemoon opened this issue May 25, 2017 · 10 comments
Labels
UI 🎨 User Interfaces
Milestone

Comments

@Aasemoon
Copy link

Hi there,

I have a request for a tiny adjustment. Could you possibly make it so that the "add to favourites" star button shows up for each item on the reading view as well? Would be very helpful I believe.

Cheers!

@Alkarex Alkarex modified the milestone: 1.8.0 May 26, 2017
@Alkarex Alkarex added the UI 🎨 User Interfaces label May 26, 2017
@Alkarex
Copy link
Member

Alkarex commented May 26, 2017

Related to #1400

@Alkarex
Copy link
Member

Alkarex commented May 26, 2017

Thanks @Aasemoon
Planned for 1.8.0.

@Aasemoon
Copy link
Author

@Alkarex Great! Thanks! =)

aledeg added a commit to aledeg/FreshRSS that referenced this issue Jan 3, 2018
I've got the inspiration from the mark as read action. So I've used the id of the feed to trigger the action and not the url in the link. This way, it works all the time. It works in reading mode, it works in normal mode when icon are not displayed.

See FreshRSS#1545
@aledeg
Copy link
Member

aledeg commented Jan 3, 2018

@Aasemoon Could you check the PR I've just made and tell me if it suits your needs?

@Aasemoon
Copy link
Author

Aasemoon commented Jan 3, 2018

Hi @aledeg, hmmm I'm not sure exactly what I'm missing, but when I apply the suggested changes to my main.js, I don't see anything different in the reading view. Is that the only file you have changed?

@aledeg
Copy link
Member

aledeg commented Jan 3, 2018

There is nothing different in the view. But you can use the shortcut available in the normal view. I was wondering if that change is enough for you or if we need to go a bit further. Thank you

@Aasemoon
Copy link
Author

Aasemoon commented Jan 3, 2018

@aledeg , aha, then I guess not. I'd like an "add to favourite" button on the reading view mainly because usually I view my feeds on various tablets. Keyboard shortcuts I've basically never used.

@aledeg
Copy link
Member

aledeg commented Jan 3, 2018

Thank you for your feedback. I'll try to add something in the view. I am not very comfortable with front-end but I'll give it a try.

@Aasemoon
Copy link
Author

Aasemoon commented Jan 3, 2018

@aledeg Thanks a lot! That would be great. =)

aledeg added a commit to aledeg/FreshRSS that referenced this issue Jan 3, 2018
I've got the inspiration from the mark as read action. So I've used the id of the feed to trigger the action and not the url in the link. This way, it works all the time. It works in reading mode, it works in normal mode when icon are not displayed.

See FreshRSS#1545
aledeg added a commit to aledeg/FreshRSS that referenced this issue Jan 11, 2018
I've got the inspiration from the mark as read action. So I've used the id of the feed to trigger the action and not the url in the link. This way, it works all the time. It works in reading mode, it works in normal mode when icon are not displayed.

See FreshRSS#1545
aledeg added a commit to aledeg/FreshRSS that referenced this issue Jan 11, 2018
I've got the inspiration from the mark as read action. So I've used the id of the feed to trigger the action and not the url in the link. This way, it works all the time. It works in reading mode, it works in normal mode when icon are not displayed.

See FreshRSS#1545
Alkarex pushed a commit that referenced this issue Jan 11, 2018
I've got the inspiration from the mark as read action. So I've used the id of the feed to trigger the action and not the url in the link. This way, it works all the time. It works in reading mode, it works in normal mode when icon are not displayed.

See #1545
@aledeg
Copy link
Member

aledeg commented Jan 11, 2018

@Aasemoon The PR is merged. Does it covers what you had in mind?
If yes, I suggest we close that issue.

@Alkarex Alkarex closed this as completed Jan 26, 2018
Alkarex added a commit that referenced this issue Jan 26, 2018
@Alkarex Alkarex modified the milestones: 1.11.0, 1.10.0 Feb 5, 2018
javerous pushed a commit to javerous/FreshRSS that referenced this issue Jan 20, 2020
I've got the inspiration from the mark as read action. So I've used the id of the feed to trigger the action and not the url in the link. This way, it works all the time. It works in reading mode, it works in normal mode when icon are not displayed.

See FreshRSS#1545
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this issue Mar 25, 2021
I've got the inspiration from the mark as read action. So I've used the id of the feed to trigger the action and not the url in the link. This way, it works all the time. It works in reading mode, it works in normal mode when icon are not displayed.

See FreshRSS#1545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

No branches or pull requests

3 participants