Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Limit height of "Mark all read" button in the footer #2251

Closed
uncovery opened this issue Feb 14, 2019 · 4 comments
Closed

Comments

@uncovery
Copy link
Contributor

Currently, the "Mark all read" footer below the article list is stretching 100% until the bottom of the page. Instead, it should be a fixed-height bar/button below the articles.

Why?

  • If you have only a few articles unread left in your feed, the whole page essentially becomes a "mark all read" button.

  • This leaves zero space to click on the page to switch between windows without clicking on the button:
    image

In this scenario, I would instinctively, inadvertently click on "Mark all read" when trying to switch to the browser from Notepad. The white area in a website is usually safe to click. Not in FreshRSS.

  • It's poor interface design. Buttons should be easily understood as such and not be a massive white space that occupies the whole page.
@Frenzie Frenzie added the UI 🎨 User Interfaces label Feb 14, 2019
@pattems
Copy link
Contributor

pattems commented Mar 16, 2019

This functions like it does to give people who use scroll as read enough room to scroll to the last article to mark it read with scrolling, and not click on the giant button. It's not a design choice I personally like, but that was the rationale that was given to me while I was writing my theme. It's on my list of UI areas to take a crack at improving, when I've got time.

@uncovery
Copy link
Contributor Author

uncovery commented Mar 18, 2019

thanks for your reply. I get your point and agree the footer should be large, but not the button. I will reword the request to make sure I don't intend to shorten the footer, rather the button size. There could of course be another footer below a button, just without the whole surface being a button.

@uncovery uncovery changed the title [Feature Request] Limit height of "Mark all read" footer [Feature Request] Limit height of "Mark all read" button in the footer Mar 18, 2019
@Alkarex
Copy link
Member

Alkarex commented Mar 19, 2019

All right. We could reduce a bit the width of the active area, to leave a bit of room on both sides for neutral clicks.

@Alkarex Alkarex added this to the 1.15.0 milestone Mar 19, 2019
Alkarex pushed a commit that referenced this issue Jul 13, 2019
* Change to fix issues 2251

This is a proposed change to fix issue #2251

* Remove comments
@Alkarex
Copy link
Member

Alkarex commented Jul 13, 2019

Fixed by @uncovery in #2301

@Alkarex Alkarex closed this as completed Jul 13, 2019
@Alkarex Alkarex modified the milestones: 1.15.0, 1.14.3 Jul 13, 2019
javerous pushed a commit to javerous/FreshRSS that referenced this issue Jan 20, 2020
* Change to fix issues 2251

This is a proposed change to fix issue FreshRSS#2251

* Remove comments
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this issue Mar 25, 2021
* Change to fix issues 2251

This is a proposed change to fix issue FreshRSS#2251

* Remove comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants