Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts problem when showing articles unfolded #2328

Closed
Pitel opened this issue Apr 2, 2019 · 14 comments
Closed

Shortcuts problem when showing articles unfolded #2328

Pitel opened this issue Apr 2, 2019 · 14 comments
Labels
UI 🎨 User Interfaces
Milestone

Comments

@Pitel
Copy link

Pitel commented Apr 2, 2019

j/k now (1.14.0) seems to jump by whole page, not article. It was ok in 1.13.

Chrome 75.0.3745.4, Linux

@Frenzie Frenzie changed the title Keyboard shortcuts became useless Keyboard shortcuts not working on Chromium 75 Apr 2, 2019
@Frenzie Frenzie changed the title Keyboard shortcuts not working on Chromium 75 Keyboard shortcuts not working on Chromium Apr 2, 2019
@Frenzie
Copy link
Member

Frenzie commented Apr 2, 2019

What do you mean by "whole page" precisely?

@Frenzie Frenzie added UI 🎨 User Interfaces and removed Important 🔥 labels Apr 2, 2019
@ggdagg
Copy link

ggdagg commented Apr 2, 2019

I confirm that I have the same symptom since Freshrss 1.14.0, however it's with Firefox 66.0.1. Before when I used j/k shortcuts it was opening the next/previous article, and the title of the article was at the top of the screen. Now it randomly open the next/previous article in the middle of the article itself, or even jump an article and ends up in the middle of the next one. I have the same issue with the navigation arrows. My options are “normal view”, “show only unread”, “show articles unfolded by default”. For testing, I also tried different themes, but the problem is still here.

Tested on 2 different Firefox 66.0.1 on Linux.

@Alkarex Alkarex added this to the 1.14.1 milestone Apr 2, 2019
@Alkarex
Copy link
Member

Alkarex commented Apr 2, 2019

@Frenzie Were you able to reproduce the issue? I could not (tested on Ubuntu 18.04 LTS with Firefox 66 and Chromium 73)
@Pitel and @ggdagg Could you please try our /dev branch (upcoming 1.14.1), where I have just fixed a number of things regarding shortcuts and mouse clicks?

@Frenzie
Copy link
Member

Frenzie commented Apr 3, 2019

No, I wasn't.

@ggdagg
Copy link

ggdagg commented Apr 3, 2019

I just tried with 1.14.1-dev, and unfortunately I still have the same issue. Here is a GIF of the test I did, and might help you understand better what I meant: https://imgur.com/a/RPFGPD1
I also tried again with the keyboard shortcuts, and it's also the same. Even worst I would say since the "open next article" key just goes at the bottom of the page and marks all articles as read in my case. This is not shown on the GIF.

It has been test with a brand-new database, same options as before (“normal view”, “show only unread”, “show articles unfolded by default”), and tried on Windows and Linux with Firefox 60.0.2 and 60.6.0esr, respectively.

@Frenzie
Copy link
Member

Frenzie commented Apr 3, 2019

Just a shot in the dark here, but on what kind of OS and filesystem are you running the server? Is it possible that something's going wrong with the filemtime() so that you're getting the cached version of the older script or something along those lines?

It'll be in the first few lines of the HTML source:

<script src="../scripts/main.js?1554061833" defer="defer" async="async"></script>

If you're missing a number, a full refresh (Ctrl+F5) should probably suffice. If there is a number, put the number in https://www.epochconverter.com/ and see if it says something recent. I.e., any result older than about 3 or 4 days ago probably means something's wrong. If so, please share the result and more server details.

For example, my number there converts to Sunday, March 31, 2019 7:50:33 PM UTC, when I updated to 1.14 final.

@Pitel
Copy link
Author

Pitel commented Apr 3, 2019

1554283442 -> 2 days ago.

And my server is Raspberry Pi with latest Raspbian and NginX + PHP 7.3.3.

@ggdagg
Copy link

ggdagg commented Apr 3, 2019

Mine is:
<script src="../scripts/main.js?1554273549" defer="defer" async="async"></script>

Following your information, 1554273549 is GMT: Wednesday, 3 April 2019 06:39:09.

Details about my server:

  • CentOS 7.6.1810
  • Filesystem XFS
  • Apache/2.4.38
  • PHP 7.2.13

@Alkarex
Copy link
Member

Alkarex commented Apr 3, 2019

I can reproduce a similar problem with the option Show articles unfolded by default

@Alkarex Alkarex changed the title Keyboard shortcuts not working on Chromium Shortcuts problem when showing articles unfolded by default Apr 3, 2019
@Alkarex Alkarex changed the title Shortcuts problem when showing articles unfolded by default Shortcuts problem when showing articles unfolded Apr 3, 2019
Alkarex added a commit to Alkarex/FreshRSS that referenced this issue Apr 3, 2019
@Alkarex
Copy link
Member

Alkarex commented Apr 3, 2019

Should be fixed with #2336
Tests welcome

@Alkarex
Copy link
Member

Alkarex commented Apr 3, 2019

Merged in the /dev branch. Additional tests welcome

Alkarex added a commit that referenced this issue Apr 3, 2019
@Pitel
Copy link
Author

Pitel commented Apr 4, 2019

Confirming fixed in dev branch. 👍 🎉

@ggdagg
Copy link

ggdagg commented Apr 4, 2019

Yes same on my side I confirm that you fixed the problem! Thanks for this quick fix :)

@Alkarex
Copy link
Member

Alkarex commented Apr 4, 2019

Thanks for the quick feedback :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

No branches or pull requests

4 participants