Data deletion during 1.15.0 update #2619
Comments
|
I'm tagging this as important because it definitely sounds like a bug. However, nothing of the sort happened to me when I tested updating a few different systems. Could there potentially have been a lack of diskspace or something of the kind involved? |
|
I have checked it and the disk where FreshRSS is located is full at 51% so that is not the issue. Could this be a git related problem? I mean, as the user data and config files are not tracked by git, is it possible that the update process has removed all to apply the repository state of the data directory? |
|
It seems to execute a |
|
@Reman38 No, those files are not supposed to be deleted. Did you install by git? |
|
Yes, git is installed on the server.
Moreover, I have checked my backups and both of them are missing (hidden files are part of the backup since .htaccess file is present) at least since September 1st which is my oldest backup (at this time the version was already 1.14.3). Thus, the first gitignore file has probably been added by the current update. For your information I followed the documentation to install FreshRSS and since this I always used the GUI to update without problem until today. I never moved this installation or manually removed filed in the FreshRSS directory. |
|
By taking a quick glance at |
|
@marienfressinaud Cleaning is needed before checking out, otherwise if a file exist or has been modified, checking out would fail. See #2036 @Reman38 Any idea of what could have deleted https://github.com/FreshRSS/FreshRSS/blob/dev/data/users/.gitignore in your setup? |
|
P.S. @marienfressinaud I did not see your |
|
A fetch + reset seems to be more robust https://stackoverflow.com/a/9589927 and with the additional benefit that we might be able to remove our |
|
How is |
Fix FreshRSS#2619 Avoid potentially dangerous git clean, and use more robust fetch + reset strategy instead
No idea. Since no other processes than Nginx can write into the FreshRSS directory, the only idea that comes into my mind is another strange issue during the previous update that has removed the .gitignore. |
|
@Reman38 Could you please show the output of the following commands? cd ./FreshRSS/
git status -v
git remote -v
git branch -v |
Fix #2619 Avoid potentially dangerous git clean, and use more robust fetch + reset strategy instead
Sorry for the delay, I was AFK this week-end. git status -v git remote -v: git branch -v: |
|
@Reman38 Ok, it looks like several files have been modified locally. In particular a bunch of |
|
After resetting the .gitignore deletions, I have updated FreshRSS to 1.15.1 without problems. Thank you for your help! |
Fix FreshRSS#2619 Avoid potentially dangerous git clean, and use more robust fetch + reset strategy instead
Hello,
After receiving the rss post about the 1.15.0 update, I decided to do it (using the UI). After clicking on the "update" button, I was redirected to the 403 error file. According to the nginx logs, I discovered that the users directories (in data/users) and the config.php file had been deleted during the process.
I have restored these files using my backup and regardless this point the update seems to be correct.
Nevertheless, is this deletion a normal part of this particular update? If yes, it seems important to inform administrators of this behavior. Especially because the UI gives the impression of a smooth process and in this case it was not really the case.
If it is a bug, here are the technical details:
I can't provide any FreshRSS logs since they were in the deleted directories.
Nginx logs:
The text was updated successfully, but these errors were encountered: