Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Clicking next to article makes it collapse #4713

Closed
alexounet2 opened this issue Oct 11, 2022 · 11 comments · Fixed by #4736
Closed

[BUG] Clicking next to article makes it collapse #4713

alexounet2 opened this issue Oct 11, 2022 · 11 comments · Fixed by #4736
Labels
Discussion UI 🎨 User Interfaces
Milestone

Comments

@alexounet2
Copy link

alexounet2 commented Oct 11, 2022

Issue:
When clicking next to an open article (and also when selecting text and releasing the mouse button in this area), the article collapses. I'm reporting this as a bug since there is no visual feedback ("click"-cursor) for this, unlike on the article header.

Steps to reproduce the behavior:

  1. Open article
  2. Click on the margin of the content < div> (see screenshot)
  3. Article collapses as if its header was clicked

Expected behavior:
Nothing should happen.

image

Environment information (please complete the following information):

  • Device: PC with a large enough screen
  • OS: any (tested on Windows 10 and EndeavourOS)
  • Browser: any (tested on Chrome 106 and Firefox 105)
  • FreshRSS version: 1.20.0
  • PHP version: 7.4.30

Suggested solution:
Make only the < li> "item title" clickable for the collapsing behaviour and not the whole < div> "flux active current" as I guess it is the case now.

PS: thanks for your great work, FreshRSS is an awesome piece of software!

@Alkarex Alkarex added the UI 🎨 User Interfaces label Oct 11, 2022
@math-GH
Copy link
Contributor

math-GH commented Oct 11, 2022

It is not a bug, it is a feature.

You can disable it in the configuration -> Reading
grafik

(IMHO I do not like this feature. It is enabled by default)

@alexounet2
Copy link
Author

Thanks for pointing this out!

@Alwaysin
Copy link
Contributor

Alwaysin commented Oct 11, 2022

(IMHO I do not like this feature. It is enabled by default)

I second this. This + mark articles as read while scrolling, I find it very "unhealthy" and believe people actually leave because of this. It is not sane defaults to see the aricles disappear just wandering about discovering the tool.

EDIT: math, I know this has nothing to do here (:D) but its just a reaction to what you've said! I don't know if it's best to open a discussion about this, I think I've already read something about it, t surely is somewhere around here.

@math-GH
Copy link
Contributor

math-GH commented Oct 11, 2022

Let's keep open this ticket for a short discussion.

@math-GH math-GH reopened this Oct 11, 2022
@math-GH
Copy link
Contributor

math-GH commented Oct 11, 2022

ping @Alkarex @Frenzie @aledeg

@Frenzie
Copy link
Member

Frenzie commented Oct 11, 2022

I'm strongly in favor of not doing that.

Edit: also see #1539 (comment)

@Alkarex
Copy link
Member

Alkarex commented Oct 11, 2022

I do not really mind, but otherwise edging on the side of having this option disabled by default.

@Alkarex Alkarex added this to the 1.20.1 milestone Oct 11, 2022
@aledeg
Copy link
Member

aledeg commented Oct 15, 2022

I'm strongly in favor of not doing that.

Edit: also see #1539 (comment)

What do you mean by "that"? Changing the default value of the parameter?

@Alwaysin
Copy link
Contributor

I also didn't get the comment. It looks from the comment linked that he has the same opinon than us: not having the "Clicking outside of article text area closes the article" checked by default.
I'd like to emphasize again the fact that I find it healthier to have the setting "mark articles as read while scrolling" as not checked by default either.

@Frenzie
Copy link
Member

Frenzie commented Oct 15, 2022

What do you mean by "that"? Changing the default value of the parameter?

That as in "When clicking next to an open article (and also when selecting text and releasing the mouse button in this area), the article collapses." Unexpectedly marking things as read/closing/etc. just because you happened to click outside of some invisible zone is awful.

@aledeg
Copy link
Member

aledeg commented Oct 15, 2022

Ok, so we can change the default value as it seems that everyone agrees :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants