Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for not closing article after pressing outside article area #1539

Merged
merged 10 commits into from May 26, 2017
Merged

Option for not closing article after pressing outside article area #1539

merged 10 commits into from May 26, 2017

Conversation

psukys
Copy link
Contributor

@psukys psukys commented May 22, 2017

Added additional configuration setting for #1530 . This includes default settings and translation entry for English.

@Alkarex Alkarex added this to the 1.7.0 milestone May 22, 2017
@Alkarex Alkarex added the UI 🎨 User Interfaces label May 22, 2017
@Alkarex
Copy link
Member

Alkarex commented May 22, 2017

Let's try to make some more translations (I will do a few)

hoilc added a commit to hoilc/FreshRSS that referenced this pull request May 23, 2017
@@ -93,6 +93,7 @@
'display_categories_unfolded' => 'Show categories folded by default',
'hide_read_feeds' => 'Hide categories & feeds with no unread articles (does not work with “Show all articles” configuration)',
'img_with_lazyload' => 'Use "lazy load" mode to load pictures',
'sides_close_article' => 'Clicking outside of article text area closes the article',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add this line to all other languages, suffixed with a TODO?

'sides_close_article' => 'Clicking outside of article text area closes the article', //TODO

@Alkarex
Copy link
Member

Alkarex commented May 25, 2017

Please add yourself to https://github.com/FreshRSS/FreshRSS/blob/dev/CREDITS.md

@psukys
Copy link
Contributor Author

psukys commented May 25, 2017

@Alkarex added the line to other languages with TODO comment. Also added myself to credits

@Alkarex Alkarex merged commit b2cbbd6 into FreshRSS:dev May 26, 2017
@Alkarex
Copy link
Member

Alkarex commented May 26, 2017

Thanks @psukys !
Merged with a few changes. Please test /dev version if you can.

@Frenzie
Copy link
Member

Frenzie commented May 27, 2017

Awesome! I never liked that but my annoyance with it was extremely minor. :-)

@psukys psukys deleted the dev branch May 27, 2017 19:41
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
Option for not closing article after pressing outside article area
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants