-
-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Installation process step 3 not possible when already integrated in traefik and authelia #5357
Comments
Thanks for the bug report. Should be fixed by #5358 (not much tested yet) To test, you can for instance instruct your Docker or docker-compose to build from git: build:
context: https://github.com/Alkarex/FreshRSS.git#trusted_sources-install
dockerfile: Docker/Dockerfile-Alpine |
OK: Still an issue:
There should be at least an information that these data has to manually changed by the admin. Thanks for the quick response to my issue. |
* Automatic trusted_sources during install Fix #5357 * Fix install for http_auth * Update lib/lib_rss.php Co-authored-by: Luc SANCHEZ <4697568+ColonelMoutarde@users.noreply.github.com> * Fill null exception e-mail * Revert some syntax * Minor parentheses
Related change: #5549 |
* Rework trusted proxies Fix #5502 Follow-up of #3226 New environment variable `TRUSTED_PROXY`: set to 0 to disable, or to a list of trusted IP ranges compatible with https://httpd.apache.org/docs/current/mod/mod_remoteip.html#remoteiptrustedproxy New internal environment variable `CONN_REMOTE_ADDR` to remember the true IP address of the connection (e.g. last proxy), even when using mod_remoteip. Current working setups should not observe any significant change. * Minor whitespace * Safer trusted sources during install Rework of #5358 #5357 * Minor readme
Describe the bug
If you use the Docker image from linux servers (lscr.io/linuxserver/freshrss), there will be a fatal error thrown when calling httpAuthUser() in step 3 of the installation.
httpAuthUser will call checkTrustedIP but the configuration about the trusted IP is not done at this point.
This means $_SERVER['HTTP_REMOTE_USER'] is present, checkTrustedIP is executed but not configured now and there is no check if you are at the installation process.
To Reproduce
Expected behavior
At least a installation process which can be completed.
To have a full working authetication with trusted http headers will need the trusted ip configuration too which is not shown in the installation.
My personal expectation will be to have at least the checkTrustedIP function written in a way that it detects a FreshRSS installation process and accept any IP at this point.
Screenshots
n/a
Environment information (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: