API regression for user/-/state/com.google/starred

[Alkarex]

A git bisect suggests that this commit broke the GReader API (the log shows GReaderAPI::internalServerError for the route user/-/state/com.google/starred). Before this, the API worked fine, and the UI still does.

Posted by @JFronny in c72914b#commitcomment-111220080

[Alkarex]

Hello @JFronny and thanks for the bug report.
To help isolating the bug, could please tell:

• what action more precisely is triggering the bug (is it listing starred articles?)
• what database you are using (e.g. SQLite, PostgreSQL, MariaDB, MySQL)
• what PHP version
• what client you are using

[JFronny]

• it is triggered by "syncing" (reloading by "pulling down" in the article list) from Readrops (installed via F-Droid), which probably includes downloading the list of starred articles
• mysql Ver 8.0.32-0ubuntu0.22.04.2 for Linux on x86_64 ((Ubuntu)) in an otherwise clean Proxmox LXC container with Ubuntu 22.04
• PHP 8.1.2-1ubuntu2.11 via apache2 (as is recommended in the docs)
• Readrops 1.3.1 (installed from F-Droid)

[Alkarex]

Do you have any stack trace in your logs or similar?

Edit: in your FreshRSS and/or Web server logs.
FreshRSS logs are found in ./data/users/*/log*.txt

[franztv82]

Hello,
i'm having the same issue. My apache error log throws this when the error occurs:

[Sun Apr 30 13:09:59.444128 2023] [proxy_fcgi:error] [pid 869:tid 139693794788928] [client 192.168.100.109:51500] AH0107
1: Got error 'PHP message: PHP Fatal error: Uncaught ValueError: PDOStatement::bindValue(): Argument #1 ($param) must b
e greater than or equal to 1 in /usr/share/FreshRSS/lib/Minz/ModelPdo.php:200\nStack trace:\n#0 /usr/share/FreshRSS/lib/
Minz/ModelPdo.php(200): PDOStatement->bindValue()\n#1 /usr/share/FreshRSS/lib/Minz/ModelPdo.php(240): Minz_ModelPdo->fet
chAny()\n#2 /usr/share/FreshRSS/app/Models/EntryDAO.php(1209): Minz_ModelPdo->fetchColumn()\n#3 /usr/share/FreshRSS/p/ap
i/greader.php(748): FreshRSS_EntryDAO->listIdsWhere()\n#4 /usr/share/FreshRSS/p/api/greader.php(1106): GReaderAPI::strea
mContentsItemsIds()\n#5 /usr/share/FreshRSS/p/api/greader.php(1209): GReaderAPI::parse()\n#6 {main}\n thrown in /usr/sh
are/FreshRSS/lib/Minz/ModelPdo.php on line 200'

Perhaps it helps...

[Alkarex]

Would you be able to give a try to this patch? #5366

[franztv82]

I'm not (yet) familiar with github. What's best practice to apply this patch?

[Alkarex]

It depends on how you installed FreshRSS.
Assuming you installed by git, you can run the following command from your FreshRSS directory:

git pull https://github.com/Alkarex/FreshRSS.git fix-api-starred

[franztv82]

Thanks, applying the patch worked fine. But the internal server error is still there. Here's my log_api.txt:

[Mon, 01 May 2023 07:56:42 +0200] [warning] --- GReaderAPI::internalServerError

In apache error log is no entry.

[Alkarex]

@franztv82 Could you please check your ./data/users/_/log_api.txt

[franztv82]

[Mon, 01 May 2023 08:20:58 +0200] [debug] --- GReaderAPI::internalServerError Array
(
    [date] => 2023-05-01T08:20:58+02:00
    [headers] => Array
        (
            [Host] => rss.franz-tv.de
            [Accept-Language] => de-DE,de;q=0.9
            [User-Agent] => NetNewsWire (RSS Reader; https://netnewswire.com/)
            [Accept-Encoding] => gzip, deflate, br
            [Accept] => */*
            [Authorization] => GoogleLogin auth=my_username/█
        )

    [_SERVER] => 
    [_GET] => Array
        (
            [n] => 1000
            [output] => json
            [s] => user/-/state/com.google/starred
        )

    [_POST] => Array
        (
        )

    [_COOKIE] => Array
        (
        )

    [INPUT] => 
)

[Alkarex]

I have made a little change to the patch. Could you please try again?

[franztv82]

Still an error, but different log:

[Mon, 01 May 2023 09:10:51 +0200] [debug] --- GReaderAPI::internalServerError Array
(
    [date] => 2023-05-01T09:10:51+02:00
    [headers] => Array
        (
            [Host] => rss.franz-tv.de
            [Accept-Language] => de-DE,de;q=0.9
            [User-Agent] => NetNewsWire (RSS Reader; https://netnewswire.com/)
            [Accept-Encoding] => gzip, deflate, br
            [Accept] => */*
            [Authorization] => GoogleLogin auth=my_username/█
        )

    [_SERVER] => 
    [_GET] => Array
        (
            [n] => 1000
            [output] => json
            [s] => user/-/state/com.google/reading-list
            [xt] => user/-/state/com.google/read
        )

    [_POST] => Array
        (
        )

    [_COOKIE] => Array
        (
        )

    [INPUT] => 
)

[Alkarex]

Could you please keep the path informations in the _SERVER section, such as $_SERVER['REQUEST_URI'], so I can see which call is failing?

[Alkarex]

Ah, I had forgotten to change a little thing in my last version of the patch. Might be fixed now, if you could please try again

[franztv82]

Thank you very much, now everything works fine!

[franztv82]

Could you please keep the path informations in the _SERVER section, such as $_SERVER['REQUEST_URI'], so I can see which call is failing?

Only for my personel interest: how can i do that? I copied the log without any changes...

[Alkarex]

Thanks for the tests and also for using the edge version.

Only for my personel interest: how can i do that? I copied the log without any changes...

Hum, strange. I would have to investigate why this debug information is empty. What PHP version?

[franztv82]

PHP 8.0.25