Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Editing user queries deletes the feed information #5514

Closed
robhuen opened this issue Jul 8, 2023 · 4 comments · Fixed by #5515
Closed

[BUG] Editing user queries deletes the feed information #5514

robhuen opened this issue Jul 8, 2023 · 4 comments · Fixed by #5515
Labels
Bug (confirmed) 🐞 issues that are reproducable
Milestone
1.22.0

Comments

@robhuen
Copy link

robhuen commented Jul 8, 2023

Describe the bug
Editing user queries deletes the feed information ('Display "..." feed') and it cannot added again via the "type" dropdown menu.

To Reproduce

  1. Create a query by
  • Selecting a feed
  • Searching
  • Using the function "bookmark current query"

-- the result is as expected.

  1. Edit the query
  • Go to 'User queries'
  • Edit the query and change e.g. only the name
  • Click Submit

-- the information on which feed the query shall be performed on is deleted.

**Environment information: **

  • Device: Mac
  • OS: Ventura 13.4.1
  • Browser: Chrome 114.0.5735.198
  • FreshRSS version: 1.21.1-dev [6f4c6f8]
  • Database version: SQLite
  • PHP version: 8.2.7
  • Installation type:
@robhuen robhuen changed the title [BUG] [BUG] Editing user queries deletes the feed information Jul 8, 2023
@robhuen
Copy link
Author

robhuen commented Jul 8, 2023

One more note:

After switching the branch from edge to latest the function works as expected.

@Alkarex Alkarex added the Bug (unconfirmed) issues thar could not reproduced yeat label Jul 9, 2023
@Alkarex Alkarex added this to the 1.22.0 milestone Jul 9, 2023
@Alkarex Alkarex added Bug (confirmed) 🐞 issues that are reproducable and removed Bug (unconfirmed) issues thar could not reproduced yeat labels Jul 9, 2023
Alkarex added a commit to Alkarex/FreshRSS that referenced this issue Jul 9, 2023
@Alkarex
Fix get and order when saving user query
574b743 
fix FreshRSS#5514
@Alkarex Alkarex mentioned this issue Jul 9, 2023
Merged
@Alkarex
Copy link
Member

Alkarex commented Jul 9, 2023

Thanks for the bug report!
Would you be able to test #5515 ?

@robhuen
Copy link
Author

robhuen commented Jul 10, 2023

Thank you for the quick help.

I switched back to edge (6f4c6f8) and applied #5515 .

--Result: Editing user queries works as expected.

Alkarex added a commit that referenced this issue Jul 10, 2023
@Alkarex
Fix get and order when saving user query (#5515)
db5d458 
fix #5514
@Alkarex
Copy link
Member

Alkarex commented Jul 10, 2023

Thanks for the feedback 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug (confirmed) 🐞 issues that are reproducable
Projects
None yet
Milestone
1.22.0
Development

Successfully merging a pull request may close this issue.

Fix get and order when saving user query Alkarex/FreshRSS
2 participants
@Alkarex @robhuen