Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update process git error #6483

Closed
i300220 opened this issue May 23, 2024 Discussed in #5174 · 4 comments · Fixed by #6496
Closed

Update process git error #6483

i300220 opened this issue May 23, 2024 Discussed in #5174 · 4 comments · Fixed by #6496
Labels
Bug (unconfirmed) issues thar could not reproduced yeat Update action 💾
Milestone

Comments

@i300220
Copy link

i300220 commented May 23, 2024

Discussed in #5174

Originally posted by zero77 March 5, 2023
Describe the bug
Before 1.21.0 stable release the dev updates worked correctly now they fail to update.
After clicking apply the following error is displayed and the update fails.

To Reproduce
Steps to reproduce the behavior:

  1. Go to settings
  2. Click on Apply under updates
  3. Updates fail and show an error message
  4. See error

Expected behavior

Screenshots

Screenshot

Environment information (please complete the following information):

  • Device: Firefox for Linux
  • OS: Debian 11
  • Browser: Firefox 102.8.0
  • FreshRSS version: 1.21.0-dev
  • Database version: [e.g. Mysql 5.7]
  • PHP version: 7.4.33
  • Installation type: Apache

Additional context

@Alkarex Alkarex added this to the 1.24.1 milestone May 23, 2024
@math-GH math-GH added Bug (unconfirmed) issues thar could not reproduced yeat Update action 💾 labels May 23, 2024
Alkarex added a commit to Alkarex/FreshRSS that referenced this issue May 25, 2024
@Alkarex
Copy link
Member

Alkarex commented May 25, 2024

Hello,
I have added better git error messages and suggestions of fixes in #6496

Please give it a try if you can.

The most likely problem you faced is:

$ git symbolic-ref --short HEAD
fatal: detected dubious ownership in repository at '/var/www/FreshRSS'

And the proposed solution is: Reapply chown www-data:www-data -R /var/www/FreshRSS/

@i300220
Copy link
Author

i300220 commented May 25, 2024

Hi @Alkarex

Looks fine here with the current ownership:

$ git symbolic-ref --short HEAD
latest

Taking note of your proposed solution though.

Not sure your better error messages would help me, I've never been able to see any log messages related to Minz. Only those related to Simplepie shows in the logs. Found absolutely nothing in the GUI or in the config files pointing me to a solution.

Maybe better checkinstall would do it - https://FreshRSS/p/i/?c=update&a=checkInstall ?

@Alkarex
Copy link
Member

Alkarex commented May 26, 2024

The error messages will be shown in the on-screen pop-up just like you have in your screenshot

@Alkarex
Copy link
Member

Alkarex commented May 26, 2024

P.S. You manual test is likely working because it is not the same user (typically www-data) than what PHP runs.

Alkarex added a commit that referenced this issue May 26, 2024
* Better git error messages
fix #5174
fix #6483

* Avoid dependency on `which`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug (unconfirmed) issues thar could not reproduced yeat Update action 💾
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants