Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreshRSS stops working correctly if an ajax request results in a 403 #751

Closed
mlaily opened this issue Jan 16, 2015 · 2 comments
Closed

FreshRSS stops working correctly if an ajax request results in a 403 #751

mlaily opened this issue Jan 16, 2015 · 2 comments

Comments

@mlaily
Copy link
Contributor

mlaily commented Jan 16, 2015

I have mod_evasive installed to prevent my web server from being DoSed too easily : if someone issue too many requests, they get a 403 for a short while.

If I keep pressing j or k to navigate through the articles, I end up triggering the DoS protection, and the "mark as read" ajax request fails with a 403 Forbidden error.

The problem is, this 403 error is probably not handled by FreshRSS, and it prevents any more ajax requests from working at all.

All the buttons depending on ajax then become completely useless until I refresh the whole page.
marienfressinaud added a commit that referenced this issue Jan 18, 2015
@marienfressinaud
Fix Minz_Error and error_Controller
d91a924 
- Error code and logs was not propagated from Minz_Error to the controller
- header was bad (200 instead of 404 or 403)

Related to #751
marienfressinaud added a commit that referenced this issue Jan 18, 2015
@marienfressinaud
Improve behavior when mark as read / favorite fail
14206ac 
If the request fails:
- Open a notification to inform user
- Remove pending index from the pending_feeds list

Fix #751
@marienfressinaud
Copy link
Member

I can't avoid your 403 error but now, if a request fails a feedback is given and it should not lock the interface.

@mlaily
Copy link
Contributor Author

mlaily commented Jan 18, 2015

Just what I was hoping for! thanks.
(I'll wait for the change to make it to the beta branch before I test it though)

@mlaily mlaily mentioned this issue Jan 29, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marienfressinaud @mlaily