Feed parsing: use author email when there's no author name #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A random feed where authors were not parsed properly: https://devnet.kentico.com/rss/articles I could not find which test could be extended to cover this, so I did not write any new test. |
Alkarex
reviewed
Feb 28, 2018
app/Models/Feed.php
Outdated
| @@ -355,7 +355,7 @@ public function loadEntries($feed) { | |||
| $this->id(), | |||
| $item->get_id(false, false), | |||
| $title === null ? '' : $title, | |||
| $author === null ? '' : html_only_entity_decode(strip_tags($author->name)), | |||
| $author === null ? '' : html_only_entity_decode(strip_tags($author->name === null ? $author->email : $author->name)), | |||
There was a problem hiding this comment.
I would suggest == '' instead of === null to catch other nullish values such as empty strings
There was a problem hiding this comment.
Good point, I pushed-force with a fix for that
|
Thanks! 👍 |
This is especially useful because when author is given as `<author>Author Name</author>` ( as in this example https://cyber.harvard.edu/rss/rss.html#ltauthorgtSubelementOfLtitemgt ), SimplePie will expose *Author Name* as `email`.
perrinjerome
force-pushed
the
fix/author_email
branch
from
670b7a2
to
4d6449b
Compare
Alkarex
added a commit
that referenced
this pull request
Mar 1, 2018
Merged
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
…1801) This is especially useful because when author is given as `<author>Author Name</author>` ( as in this example https://cyber.harvard.edu/rss/rss.html#ltauthorgtSubelementOfLtitemgt ), SimplePie will expose *Author Name* as `email`.
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
…1801) This is especially useful because when author is given as `<author>Author Name</author>` ( as in this example https://cyber.harvard.edu/rss/rss.html#ltauthorgtSubelementOfLtitemgt ), SimplePie will expose *Author Name* as `email`.
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially useful because when author is given as
<author>Author Name</author>( as in this examplehttps://cyber.harvard.edu/rss/rss.html#ltauthorgtSubelementOfLtitemgt ),
SimplePie will expose Author Name as
email.