Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix active check in subscription menu #1858

Merged
merged 2 commits into from
Apr 6, 2018
Merged

fix active check in subscription menu #1858

merged 2 commits into from
Apr 6, 2018

Conversation

kevinpapst
Copy link
Contributor

@kevinpapst kevinpapst commented Apr 1, 2018

The active check misbehaved:
when selecting the "Subscription tools" link, the "Subscriptions management" link was highlighted.

@Frenzie
Copy link
Member

Frenzie commented Apr 1, 2018

Ah, it took me like five seconds to understand where the problem even was but luckily there was the HTML. :-P

screenshot_2018-04-01_15-14-41

@kevinpapst
Copy link
Contributor Author

Ha, sorry for the confusion - I am using the german version and mistranslated the links in my original post (edited and now using the correct ones from your screenshot),

@Alkarex Alkarex added this to the 1.11.0 milestone Apr 4, 2018
@Alkarex
Copy link
Member

Alkarex commented Apr 4, 2018

Minor syntax changes 8528b4d

@Alkarex Alkarex added the UI 🎨 User Interfaces label Apr 4, 2018
@kevinpapst
Copy link
Contributor Author

Any objections?

@Frenzie Frenzie merged commit 6b9be92 into FreshRSS:dev Apr 6, 2018
@Frenzie
Copy link
Member

Frenzie commented Apr 6, 2018

I'll take the syntax update as implicit approval. ;-)

@kevinpapst
Copy link
Contributor Author

Thats what I thought as well :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants