Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1888 postgresql unix socket workaround #1889

Merged

Conversation

bartlomiejcieszkowski
Copy link
Contributor

#1888 this enables using of postgresql unix socket outside of installer

@Alkarex Alkarex changed the base branch from master to dev May 20, 2018 14:58
@Alkarex Alkarex added this to the 1.11.0 milestone May 20, 2018
@Alkarex
Copy link
Member

Alkarex commented May 20, 2018

Thanks @bartlomiejcieszkowski
You have made the change for MySQL. You might want to do do the same for PostgreSQL.
I suggest you introduce a boolean variable $isSocket line 57 instead of the inline test.

@Alkarex
Copy link
Member

Alkarex commented May 26, 2018

@bartlomiejcieszkowski I have changed the code to support PostgreSQL in addition to MyQSL.
Could you please check that it works for you?

@Alkarex Alkarex self-assigned this May 26, 2018
@Alkarex Alkarex merged commit 0ffc006 into FreshRSS:dev May 26, 2018
@Alkarex
Copy link
Member

Alkarex commented May 26, 2018

Related to #1364 , #1366

Alkarex added a commit that referenced this pull request May 26, 2018
@bartlomiejcieszkowski
Copy link
Contributor Author

sorry, i hadn't lately time to look at issue, change looks ok after your tweaks, glad to help - i must say it's blazing fast - tried earlier tiny tiny rss but the performance was terrible - even with single user - but here it works without hiccup on cheap vps

@bartlomiejcieszkowski bartlomiejcieszkowski deleted the 1888-postgresql-unix-socket branch May 29, 2018 18:13
@Alkarex
Copy link
Member

Alkarex commented May 29, 2018

Thanks for the feedback, @bartlomiejcieszkowski 👍

javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
* Workaround to enable postgres unix socket instead of tcp

* Support Unix sockets for MySQL and PostgreSQL
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
* Workaround to enable postgres unix socket instead of tcp

* Support Unix sockets for MySQL and PostgreSQL
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
@kgraefe kgraefe mentioned this pull request Mar 5, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants