Fever fixes #1931
Merged
Fever fixes #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was hardcoded for MySQL. Bug in "before" parameter. Bug in mark all as read.
|
The lack of "before" parameter from the clients is quite problematic, as newer articles than the last synchronisation with the client will be marked as read erroneously. There is also a few TODOs in the code to address |
|
I hear from a user that Fiery crashed when marking a category as read |
Alkarex
commented
Jun 12, 2018
| $dao = $this->getDaoForCategories(); | ||
| if (isset($_REQUEST["group_ids"])) { | ||
| $group_ids = explode(",", $_REQUEST["group_ids"]); | ||
| if (isset($_REQUEST['group_ids'])) { |
There was a problem hiding this comment.
I cannot find any mention of a group_ids parameter in the documentation https://feedafever.com/api .
There is however a group_id one.
|
Merging in /dev to make it easier for testers |
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
* Fever fixes Was hardcoded for MySQL. Bug in "before" parameter. Bug in mark all as read. * Fix construct * Changelog 1930 FreshRSS#193 FreshRSS#1931
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* Fever fixes Was hardcoded for MySQL. Bug in "before" parameter. Bug in mark all as read. * Fix construct * Changelog 1930 FreshRSS#193 FreshRSS#1931
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was hardcoded for MySQL. Bug in "before" parameter. Bug in mark all as read.
#1930