Remove some preload / prefetch #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This approach was only efficient in the specific case when no change was made (no mark-as-read, favourites, tags), and useless in the other situations. Removed to reduce server load.
Frenzie
approved these changes
Oct 7, 2018
While useful for the first request, those preload / prefetch hints are slightly negative for the following requets, especially server-side, e.g. generating one log entry in Apache, and a bit more network traffic.
|
Revert a sub-part of #1133 |
aledeg
reviewed
Oct 7, 2018
app/FreshRSS.php
Outdated
| @@ -90,7 +90,7 @@ public static function loadStylesAndScripts() { | |||
| } | |||
| $filetime = @filemtime(PUBLIC_PATH . '/themes/' . $theme_id . '/' . $filename); | |||
| $url = '/themes/' . $theme_id . '/' . $filename . '?' . $filetime; | |||
| header('Link: <' . Minz_Url::display($url, '', 'root') . '>;rel=preload', false); //HTTP2 | |||
| //header('Link: <' . Minz_Url::display($url, '', 'root') . '>;rel=preload', false); //HTTP2 | |||
There was a problem hiding this comment.
If it's useless, it's better to remove it completely.
There was a problem hiding this comment.
Removed in a666cd8
It might be useful associated with a smarter way of guessing whether the client needs it or not (e.g. first request)
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Oct 13, 2018
The fast flush optimisation done in FreshRSS#1133 does not seem to work anymore (need to check if it is related to a PHP version). Work-around when PHP flush() is not working Can be tested by adding a `sleep(5);` after: https://github.com/FreshRSS/FreshRSS/blob/ee902ee7c4370421802768c3105ba269a4f97b16/app/layout/layout.phtml#L27 Follow-up of the performance checks of FreshRSS#2040
Alkarex
added a commit
that referenced
this pull request
Oct 14, 2018
Alkarex
added a commit
that referenced
this pull request
Oct 14, 2018
* Ensure fast flush of HTTP headers and HTML head The fast flush optimisation done in #1133 does not seem to work anymore (need to check if it is related to a PHP version). Work-around when PHP flush() is not working Can be tested by adding a `sleep(5);` after: https://github.com/FreshRSS/FreshRSS/blob/ee902ee7c4370421802768c3105ba269a4f97b16/app/layout/layout.phtml#L27 Follow-up of the performance checks of #2040 * output_buffering in .user.ini for PHP CGI / FPM * Reuse .user.ini for Docker PHP config * Longer flush Flush a bit later, to be compatible with the default value of 4096 for PHP output_buffering, and thus avoid the need of tuning the value.
Merged
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
* Remove next prefetch This approach was only efficient in the specific case when no change was made (no mark-as-read, favourites, tags), and useless in the other situations. Removed to reduce server load. * Remove next prefetch from JavaScript too * Remove some preload / prefetch While useful for the first request, those preload / prefetch hints are slightly negative for the following requets, especially server-side, e.g. generating one log entry in Apache, and a bit more network traffic. * Revert mistake * Remove comment FreshRSS#2040 (comment)
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
* Ensure fast flush of HTTP headers and HTML head The fast flush optimisation done in FreshRSS#1133 does not seem to work anymore (need to check if it is related to a PHP version). Work-around when PHP flush() is not working Can be tested by adding a `sleep(5);` after: https://github.com/FreshRSS/FreshRSS/blob/ee902ee7c4370421802768c3105ba269a4f97b16/app/layout/layout.phtml#L27 Follow-up of the performance checks of FreshRSS#2040 * output_buffering in .user.ini for PHP CGI / FPM * Reuse .user.ini for Docker PHP config * Longer flush Flush a bit later, to be compatible with the default value of 4096 for PHP output_buffering, and thus avoid the need of tuning the value.
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* Remove next prefetch This approach was only efficient in the specific case when no change was made (no mark-as-read, favourites, tags), and useless in the other situations. Removed to reduce server load. * Remove next prefetch from JavaScript too * Remove some preload / prefetch While useful for the first request, those preload / prefetch hints are slightly negative for the following requets, especially server-side, e.g. generating one log entry in Apache, and a bit more network traffic. * Revert mistake * Remove comment FreshRSS#2040 (comment)
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* Ensure fast flush of HTTP headers and HTML head The fast flush optimisation done in FreshRSS#1133 does not seem to work anymore (need to check if it is related to a PHP version). Work-around when PHP flush() is not working Can be tested by adding a `sleep(5);` after: https://github.com/FreshRSS/FreshRSS/blob/ee902ee7c4370421802768c3105ba269a4f97b16/app/layout/layout.phtml#L27 Follow-up of the performance checks of FreshRSS#2040 * output_buffering in .user.ini for PHP CGI / FPM * Reuse .user.ini for Docker PHP config * Longer flush Flush a bit later, to be compatible with the default value of 4096 for PHP output_buffering, and thus avoid the need of tuning the value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach was only efficient in the specific case when no change was made while reading the first page (no mark-as-read, favourites, tags), and useless in the other situations.
Removed to reduce server load.