Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent window opener vulnerability with space shortcut #2506

Merged
merged 2 commits into from Aug 21, 2019
Merged

Prevent window opener vulnerability with space shortcut #2506

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2275466
Prevent window opener vulnerability with space shortcut
ArthurHoaro Aug 20, 2019
355fb1b
Test for popup blockers
Alkarex Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion p/scripts/main.js
View file
Open in desktop
Expand Up @@ -803,7 +803,9 @@ function init_shortcuts() {
if (context.auto_mark_site) {
mark_read(document.querySelector('.flux.current'), true, false);
}
window.open(document.querySelector('.flux.current a.go_website').href);
const newWindow = window.open();
Alkarex marked this conversation as resolved.
Show resolved Hide resolved
newWindow.opener = null;
newWindow.location = document.querySelector('.flux.current a.go_website').href;
return false;
}
if (k === s.skip_next_entry) { next_entry(true); return false; }
Expand Down