Greener Travis? #2589
Merged
Greener Travis? #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With PHP 7.4 just around the corner, I suggest to test only the minimum and maximum PHP versions we support in Travis, to save resources (greener). For the translation check, with can test with max version -1 to run on yet another PHP version. It makes also the Travis tests faster to complete.
Frenzie
approved these changes
Oct 23, 2019
There was a problem hiding this comment.
For the current tests there should be very little lost, although it seems like it might be possible php -l could miss something that's only problematic in, e.g., PHP 7.1.
Definitely not necessary for phpcs of course; that was more of a proof of concept for testing different versions and that was the only thing available at the time.
Merged
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
With PHP 7.4 just around the corner, I suggest to test only the minimum and maximum PHP versions we support in Travis, to save resources (greener). For the translation check, with can test with max version -1 to run on yet another PHP version. It makes also the Travis tests faster to complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PHP 7.4 just around the corner, I suggest to test only the minimum
and maximum PHP versions we support in Travis, to save resources
(greener).
For the translation check, with can test with max version -1 (or min version + 1, or median :-P) to run on
yet another PHP version.
It makes also the Travis tests faster to complete.