Show Favorites as Unread

[Offerel]

Closes #2434

Changes proposed in this pull request:

• added a setting in "display" to show starred/favorites as unread

How to test the feature manually:

1. got to settings > display
2. a new checkbox is available: Show Favorites as "Unread"
3. enable the checkbox
4. click on favorites/starred > url parameter state=3 is added to the link
5. if you click the favorites > read and unread articles in favorites are displayed

Pull request checklist:

• [ x ] code manually tested

Question:
Anyway, what does "show as unread" mean, with the unread background color or something?

Answer:
Color isn't changed for the articles. All will stay the same. But currently, if you click Favorites/Starred, only unread articles are displayed. In my workflow, when i star/favorite a article, it will be marked as read. Clicking now Favorite/Starred will not show that article, unless i also enable "unread" from the toolbar. This save that step and displays favorites/starred with state=3 as default. If the option is unchecked, the current behavior is used.

Hopefully, this time i get it right :-) It's a bit frickely to do that only in the WebGUI, but i didn't have my PC at hand with git installed

[Frenzie]

The proposed setting looks like this (see at the bottom):

I think it should go in reading instead. Both logically and because the "Articles to display" setting is already right there. This is a refinement of that.

I'd name the setting itself something like Always show favorites.

[Offerel]

Sure. Feel free to move that to any location you want.

[Frenzie]

Alright, since you don't have access to Git right now I can push a couple of follow-up commits if you don't mind. It's also important to add the translation as a todo to all languages. (There's a PHP helper script for that.)

[Offerel]

Nice. Many thx for that.

[Frenzie]

Alright, for the moment I made it look like this:

What I didn't realize before I looked at the code, however, is that is only affects the favorites link. So really it's more like Automatically show all articles in favorites or something along those lines. This may not be an objection to the functionality, but it currently makes the option text incorrect.

[marienfressinaud]

You'll need to define the show_fav_unread option in the default configuration file as well.

And I agree with @Frenzie that a better label can be found. Maybe "Show all articles in favorites by default" if not too long?

If you want/need to, I can make the changes myself. Also I think we can close #2535 😉 (sorry for never responding by the way :/)

[marienfressinaud]

I don't really like how it looks. Suggestion (more lines but easier to understand what's happening):

<?php
    $url_starred = _url('index', $actual_view, 'get', 's');
    if (FreshRSS_Context::$user_conf->show_fav_unread) {
        $url_starred = $url_starred . '&state=3';
    }
?>
<?= _i('bookmark') ?>
<a class="title" data-unread="<?= format_number(FreshRSS_Context::$total_starred['unread']) ?>" href="<?= $url_starred ?>">
    <?= _t('index.menu.favorites', format_number(FreshRSS_Context::$total_starred['all'])) ?>
</a>

[Frenzie]

Show all articles in favorites by default sounds good to me. Please push the changes. 👍

[marienfressinaud]

Good for me now. I just changed a bit the label from what I first suggested: "Show by default all articles in favorites". Having "by default" at the end sounded a bit like the "favorites" were "by default" and it didn't make any sense.

[Frenzie]

Sorry but no. That's ungrammatical.

Having "by default" at the end sounded a bit like the "favorites" were "by default" and it didn't make any sense.

Not really. "To X (verb) blah blah blah by default" is regular, idiomatic English. The "by default" is about the verb (to X), not about the "blah blah blah." (But I don't think that's any different in French?)

Anyway, you could always phrase it like this. The "articles" business is to remain consistent with the other settings, not by necessity.

Suggested change

	'always_show_favorites' => 'Show by default all articles in favorites',
	'always_show_favorites' => 'Show all favorites by default',

Suggested change

	'always_show_favorites' => 'Show by default all articles in favorites',
	'always_show_favorites' => 'Show read and unread favorites by default',

[marienfressinaud]

Ha ha, I was certain to make a mistake with this last-minute change :D

Not really. "To X (verb) blah blah blah by default" is regular, idiomatic English. The "by default" is about the verb (to X), not about the "blah blah blah." (But I don't think that's any different in French?)

I think French is a bit more permissive here. First form is right, but can be understood in different ways. That's why I moved the "par défaut" after "Afficher", which is also right in French and avoid the confusion. I changed the English version after that.

I'll pick your first suggestion :)

[marienfressinaud]

Edit: finally not, "Show all favorites by default" makes it sound like the first "Always show favorites". "Show all articles in favorites" was pointing the location where the option has an impact. I'll stay with my first suggestion and just adapt for French ;)

[Frenzie]

You're right, the original suggestion was best. 👍