Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darken bright elements in adark.css #3806

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Conversation

Poorchop
Copy link
Contributor

  • Table headers and box titles on the subscription management page use bright white backgrounds. This modifies these elements to use a dark background in order to be consistent with the rest of the theme.

Changes proposed in this pull request:

  • Darken bright elements in adark.css

How to test the feature manually:

  1. Load the adark.css theme and modify the stylesheet accordingly using the browser's stylesheet editor.

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

@Frenzie
Copy link
Member

Frenzie commented Aug 27, 2021

PS Before/after screenshots are helpful to add. ^_^

@Frenzie Frenzie added this to the 1.19.0 milestone Aug 27, 2021
@Poorchop
Copy link
Contributor Author

1

2

3

4

@Alkarex
Copy link
Member

Alkarex commented Aug 27, 2021

@Poorchop
Copy link
Contributor Author

Shouldn't I have also done this for #3774 in this case?

@Poorchop
Copy link
Contributor Author

I also think that I should have made the table border dark like so. If you agree, then I'd like to make this change before this gets merged.

screen shot

@Frenzie
Copy link
Member

Frenzie commented Aug 28, 2021

Ftr, you shouldn't (or in any case don't have to) do it manually. make rtl takes care of that.

@Alkarex
Copy link
Member

Alkarex commented Aug 28, 2021

I also think that I should have made the table border dark like so. If you agree, then I'd like to make this change before this gets merged.

Fine for me :-)

- Table headers and box titles on the subscription management page use bright white backgrounds. This modifies these elements to use a dark background in order to be consistent with the rest of the theme.
- This also modifies tables to have dark borders.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants