Draft:Add interface and add typehinting #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColonelMoutarde
changed the title
Alkarex
reviewed
Jan 7, 2022
app/Models/DatabaseDAO.php
Outdated
| @@ -3,7 +3,7 @@ | |||
| /** | |||
| * This class is used to test database is well-constructed. | |||
| */ | |||
| class FreshRSS_DatabaseDAO extends Minz_ModelPdo { | |||
| class FreshRSS_DatabaseDAO extends Minz_ModelPdo implements DatabaseDAOInterface { | |||
There was a problem hiding this comment.
Why an interface when there is already a base class FreshRSS_DatabaseDAO?
Alkarex
reviewed
Jan 7, 2022
app/Models/DatabaseDAOInterface.php
Outdated
Comment on lines
16
to
19
| /** | ||
| * @param array $dao | ||
| * @return array | ||
| */ |
There was a problem hiding this comment.
Comments can be removed when there is no additional information than the native type hints
|
Is it a draft or an open PR? |
|
A draft |
Alkarex
approved these changes
Feb 5, 2022
|
I have simplified and finalised this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the DatabaseDAOInterface