Added Nord based theme #4400

joelchrono12 · 2022-06-01T20:57:32Z

Closes #

Changes proposed in this pull request:

A new theme!-

How to test the feature manually:

Pick it from the settings in Display

I am still kinda noob at this so if anything else is needed please let me know

Alkarex · 2022-06-02T06:47:09Z

Hello and thanks for your contribution 👍🏻
I have automatically fixed a number of issues by running make fix-all and make test-all, but there are a few issues remaining (see the output of the automated tests below)

joelchrono12 · 2022-06-02T12:12:23Z

Hello and thanks for your contribution 👍🏻 I have automatically fixed a number of issues by running make fix-all and make test-all, but there are a few issues remaining (see the output of the automated tests below)

Thank you, do you know of how to pull the changes you did to my repo, so I can fix these problems?

Alkarex · 2022-06-02T17:19:26Z

Thank you, do you know of how to pull the changes you did to my repo, so I can fix these problems?

git pull --ff-only

math-GH · 2022-06-08T10:36:42Z

regarding your CSS:

Here you can find the defined order of CSS properties:

FreshRSS/.stylelintrc.json

Lines 40 to 65 in f85c510

    
           "order/properties-order": [ 
        
             "margin", 
        
             "padding", 
        
             "background", 
        
             "display", 
        
             "float", 
        
             "max-width", 
        
             "width", 
        
             "max-height", 
        
             "height", 
        
             "color", 
        
             "font", 
        
             "font-family", 
        
             "font-size", 
        
             "border", 
        
             "border-top", 
        
             "border-top-color", 
        
             "border-right", 
        
             "border-right-color", 
        
             "border-bottom", 
        
             "border-bottom-color", 
        
             "border-left", 
        
             "border-left-color", 
        
             "border-radius", 
        
             "box-shadow" 
        
           ],

Alkarex · 2022-06-08T11:23:37Z

For the order of attributes and other cosmetic things, running make fix-all automatically fixes all that. I have just done it, so the few remaining errors are those that must be manually handled

joelchrono12 · 2022-06-08T11:24:33Z

regarding your CSS:

Here you can find the defined order of CSS properties:

FreshRSS/.stylelintrc.json

Lines 40 to 65 in f85c510

"order/properties-order": [

"margin",

"padding",

"background",

"display",

"float",

"max-width",

"width",

"max-height",

"height",

"color",

"font",

"font-family",

"font-size",

"border",

"border-top",

"border-top-color",

"border-right",

"border-right-color",

"border-bottom",

"border-bottom-color",

"border-left",

"border-left-color",

"border-radius",

"box-shadow"

],

Thanks, I noticed there are some tests which let me know the line numbers where the css is wrong. But as I edit changes those line numbers wrong and I kinda laze around.

Is there a way to run those tests locally? I think I lack some dependencies but idk which ones, sorry if this is in the documentation, I should re-check

joelchrono12 · 2022-06-08T11:26:45Z

Well, not a lot of errors left, I'll fixed them now

Alkarex · 2022-06-08T11:29:46Z

To run tests locally, try make fix-all and make test-all
Otherwise in your case, npm install and npm run fix and npm test will cover most of what you need.
In both cases, nodejs + npm must to be available

joelchrono12 · 2022-06-08T11:38:23Z

Well now there are more errors 🙃

joelchrono12 · 2022-06-08T12:11:19Z

Hey, it passed, thank you @Alkarex I couldn't manage to get the make running since I still lacked some smaller depenencies. But now its working!

math-GH · 2022-06-08T16:48:11Z

Please check the menus in mobile view.

The "user query" submenu is broken (the white rhombus is part of the submenu)

And the config menu: the close button looks not styled:

Alkarex · 2022-06-18T18:48:17Z

Hint 2: We are using https://editorconfig.org/ to specify whitespace policies for various types of files in a standard way. This is supported by most editors, either natively or thanks to a plugin

joelchrono12 · 2022-06-18T18:53:24Z

Hint 2: We are using https://editorconfig.org/ to specify whitespace policies for various types of files in a standard way. This is supported by most editors, either natively or thanks to a plugin

Thank you, I installed the plugin for neovim and also removed some configs I had set myself that were conflicting. It should be good now! Sorry

* Document fixes & tests #fix #4213 Help #4400 (comment) * Link to tests.yml * sudo * Link to GitHub Actions * Add Fedora and Alpine

* Update all test dependencies * Remove old false-positive * Minor update lock files * Increase PHPStan memory for Fedora #4400 (comment) * Require PHP8+ for tests Due to small changes of signature in `ob_implicit_flush` and `simplexml_load_string`, cf. #4123 * Missing lint in CSS files

Alkarex · 2022-06-21T20:40:29Z

Please double-check the global view

A few things are strange, in particular the background colour of article lists:

joelchrono12 · 2022-06-21T22:13:27Z

I cannot replicate this issue, I tried both in chromium and firefox...

math-GH · 2022-06-22T16:57:30Z

Please double-check the global view

A few things are strange, in particular the background colour of article lists:

I can confirm this issue with Firefox on Windows

joelchrono12 · 2022-06-23T17:07:36Z

I can confirm this issue with Firefox on Windows

I don't really know how to solve this, my guess is that some some CSS needs an !important added to it. If any of you could find which one is it and add it it would be better since I can't get this to work...

math-GH · 2022-06-23T20:45:57Z

I can confirm this issue with Firefox on Windows

I don't really know how to solve this, my guess is that some some CSS needs an !important added to it. If any of you could find which one is it and add it it would be better since I can't get this to work...

fixed

Alkarex · 2022-07-02T18:51:54Z

Thanks again!
Please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md

Alwaysin · 2022-07-11T09:53:02Z

I like the theme! 👍

There seems to not be the new message notification banner, is this a feature?

joelchrono12 · 2022-07-11T13:04:33Z

I like the theme! 👍

There seems to not be the new message notification banner, is this a feature?

This is based on the default template and it has nothing else added.
When there are new posts available there is a little message showing up a the top of the feed, do you mean that?

Alwaysin · 2022-07-11T14:27:58Z

Yes, I meant that. Sorry, I probably had a problem on my side, it is now showing correctly!

Alwaysin · 2022-07-16T11:06:10Z

I think there's definetly a problem with this theme. On latest Chrome version on Windows, my tab of FreshRSS uses less than 200Mo of memory. When I switch to this theme, it uses circa 1Go. That's probably why it sometimes don't show the banner.
It is even more visible on a mobile phone, everything is so slow.

EDIT: Got it, the theme is loading EVERY article. I have 14000+ unread, so yeah.

math-GH · 2022-07-16T11:44:55Z

The theme has no effect on the loading behavior. The theme is just the layout (made with CSS).

How to check the resource usage in Google Chrome: https://linuxhint.com/built_in_task_manager_google_chrome/

Alwaysin · 2022-07-16T12:29:02Z

@math-GH this is the exact tool I've used to check memory status.
When using Nord theme, as soon as I scroll down, it loads every article and memory usage skyrockets. It doesn't do it on other themes.

math-GH · 2022-07-16T13:09:42Z

Loading next articles while scrolling: it is a default behavior and does not depending on the theme:

Alwaysin · 2022-07-16T13:24:59Z

Maybe I'll do a video of the behaviour if I find time to do so.
I indeed have this feature on, but on other themes, it works as described: it loads at the bottom of te page.
Ths theme, as soon as I scroll, even a millimeter, it loads everything.

math-GH · 2022-07-16T13:47:56Z

OK, now I understood and can confirm that behavior.

I created an issue ticket: #4447

joelchrono12 added 3 commits June 1, 2022 15:54

added new theme

d2f9da4

removed old picture

be7dddf

modified color of summary and author

f306942

Alkarex added the Theme label Jun 1, 2022

Alkarex added this to the 1.20.0 milestone Jun 1, 2022

Alkarex requested a review from math-GH June 1, 2022 21:36

joelchrono12 and others added 3 commits June 1, 2022 19:41

fixed input elements being hard to distinguish

2206e4c

make fix-all

faaa320

Merge branch 'edge' into edge

a1a93d3

markdown lint

510f55e

joelchrono12 added 4 commits June 2, 2022 14:13

Merge branch 'edge' of github:joelchrono12/FreshRSS into edge

8bffccc

cleaned up css, still incomplete afaik

4bed54e

removed duplicate, highlight current article

cddd63d

removed more duplicates, reordered some things

27f059f

make fix-all

4b1e52d

removed last few css duplicates

f0a3416

joelchrono12 and others added 2 commits June 8, 2022 06:48

removed empty css blocks

3be9a5b

make fix-all

28660a7

Cleaned CSS - deleted styles that are maintained in template.css

4f10dea

Alkarex added a commit that referenced this pull request Jun 19, 2022

Document fixes & tests (#4418)

238e55b

* Document fixes & tests #fix #4213 Help #4400 (comment) * Link to tests.yml * sudo * Link to GitHub Actions * Add Fedora and Alpine

Merge branch 'edge' into edge

c5418da

joelchrono12 added 3 commits June 21, 2022 17:19

border color fix

f308caf

border color fix

d8defcd

Merge branch 'edge' of github:joelchrono12/FreshRSS into edge

e8754ed

Merge branch 'edge' into edge

32b24e7

Global view: dark background

4ca2d0f

Merge branch 'edge' into edge

e538bdc

Alkarex merged commit c05ab99 into FreshRSS:edge Jul 2, 2022

math-GH mentioned this pull request Jul 16, 2022

Nord theme: loads every article #4447

Closed

math-GH mentioned this pull request Jul 17, 2022

Fix #4447: Nord theme #4451

Merged

2 tasks

math-GH mentioned this pull request Jul 31, 2022

I created a theme based on Nord's color scheme #4147

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Nord based theme #4400

Added Nord based theme #4400

joelchrono12 commented Jun 1, 2022 •

edited

Loading

Alkarex commented Jun 2, 2022

joelchrono12 commented Jun 2, 2022 •

edited by Alkarex

Loading

Alkarex commented Jun 2, 2022

math-GH commented Jun 8, 2022 •

edited

Loading

Alkarex commented Jun 8, 2022

joelchrono12 commented Jun 8, 2022

joelchrono12 commented Jun 8, 2022

Alkarex commented Jun 8, 2022 •

edited

Loading

joelchrono12 commented Jun 8, 2022

joelchrono12 commented Jun 8, 2022

math-GH commented Jun 8, 2022

Alkarex commented Jun 18, 2022

joelchrono12 commented Jun 18, 2022

Alkarex commented Jun 21, 2022

joelchrono12 commented Jun 21, 2022 •

edited

Loading

math-GH commented Jun 22, 2022

joelchrono12 commented Jun 23, 2022 •

edited

Loading

math-GH commented Jun 23, 2022

Alkarex commented Jul 2, 2022

Alwaysin commented Jul 11, 2022

joelchrono12 commented Jul 11, 2022

Alwaysin commented Jul 11, 2022

Alwaysin commented Jul 16, 2022 •

edited

Loading

math-GH commented Jul 16, 2022

Alwaysin commented Jul 16, 2022

math-GH commented Jul 16, 2022

Alwaysin commented Jul 16, 2022

math-GH commented Jul 16, 2022

Added Nord based theme #4400

Added Nord based theme #4400

Conversation

joelchrono12 commented Jun 1, 2022 • edited Loading

Alkarex commented Jun 2, 2022

joelchrono12 commented Jun 2, 2022 • edited by Alkarex Loading

Alkarex commented Jun 2, 2022

math-GH commented Jun 8, 2022 • edited Loading

Alkarex commented Jun 8, 2022

joelchrono12 commented Jun 8, 2022

joelchrono12 commented Jun 8, 2022

Alkarex commented Jun 8, 2022 • edited Loading

joelchrono12 commented Jun 8, 2022

joelchrono12 commented Jun 8, 2022

math-GH commented Jun 8, 2022

Alkarex commented Jun 18, 2022

joelchrono12 commented Jun 18, 2022

Alkarex commented Jun 21, 2022

joelchrono12 commented Jun 21, 2022 • edited Loading

math-GH commented Jun 22, 2022

joelchrono12 commented Jun 23, 2022 • edited Loading

math-GH commented Jun 23, 2022

Alkarex commented Jul 2, 2022

Alwaysin commented Jul 11, 2022

joelchrono12 commented Jul 11, 2022

Alwaysin commented Jul 11, 2022

Alwaysin commented Jul 16, 2022 • edited Loading

math-GH commented Jul 16, 2022

Alwaysin commented Jul 16, 2022

math-GH commented Jul 16, 2022

Alwaysin commented Jul 16, 2022

math-GH commented Jul 16, 2022

joelchrono12 commented Jun 1, 2022 •

edited

Loading

joelchrono12 commented Jun 2, 2022 •

edited by Alkarex

Loading

math-GH commented Jun 8, 2022 •

edited

Loading

Alkarex commented Jun 8, 2022 •

edited

Loading

joelchrono12 commented Jun 21, 2022 •

edited

Loading

joelchrono12 commented Jun 23, 2022 •

edited

Loading

Alwaysin commented Jul 16, 2022 •

edited

Loading