Fixed: "tag" -> "label" #4770
Merged
Fixed: "tag" -> "label" #4770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @Frenzie : Please check the Dutch. I labeled some lines as DIRTY |
|
Shouldn't we also modify the action to reflect that? |
|
I think, this modification should be added also on the translation key to avoid confusion. |
It would be a bigger refactoring. Also the i18n keys need a renaming. Here I just wanted to fix the text for 1.20.1 |
|
Ok then. But could you open an issue to reflect the changes I was mentioning earlier? |
aledeg
approved these changes
Oct 24, 2022
Alkarex
reviewed
Oct 24, 2022
Alkarex
approved these changes
Oct 24, 2022
Frenzie
reviewed
Oct 24, 2022
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
math-GH
added a commit
to math-GH/FreshRSS
that referenced
this pull request
Nov 15, 2022
* tag -> label (all english texts) * tag -> label (German) * marked as DIRTY * Update app/i18n/nl/feedback.php Co-authored-by: Frans de Jonge <fransdejonge@gmail.com> * Update app/i18n/nl/conf.php Co-authored-by: Frans de Jonge <fransdejonge@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
When a label is created the notification calls it a "tag".
Edit user queries:
Changes proposed in this pull request:
// DIRTYHow to test the feature manually:
check how it is called in the language:
go to "Label management" (
./p/i/?c=tag)Create a new label
see the notification
Create/edit a user query
see the filter list
Pull request checklist: