New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UI/UX install process #5147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
reviewed
Feb 27, 2023
Frenzie
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm on the screenshots, hardly tested
ColonelMoutarde
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Show password button
Before: keep the button pressed to see the password
After: same behaviour like everywhere: press the button and the password will be shown for 5 seconds.
make the menu for mobile accessable
Before: No button. No access to the hidden menu
After:
Favicon + header icon
Before:
No favicon, header icon in the middle
After:
Favicon. And header icon is on the left side as default
Navigation
Before
deactivated steps has not padding to the left border:
After
Step 1
Before:
First step does not need so much buttons for a better UX (Closes #3961)
After:
Before:
If user steps back in process:
After:
instead of a button: a text link (UX: a button saves the form, a link does not save the form)
Step 2
Before
no grey background behind the buttons
After
Before
in mobile view: no gap between the buttons
After
Before
No sub-headlines
After
similar to "installation check" in admin config
Step 4
Before
After
Step 5
Before
After
How to test the feature manually:
Pull request checklist: