TOS in footer #5222
Merged
TOS in footer #5222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alkarex
reviewed
Mar 21, 2023
| @@ -27,3 +27,9 @@ | |||
| <h1><?= _t('index.tos.title')?></h1> | |||
| <?= $this->terms_of_service ?> | |||
| </main> | |||
|
|
|||
| <?php if (!FreshRSS_Auth::hasAccess()) { ?> | |||
There was a problem hiding this comment.
Probably fine, but why the special case here?
There was a problem hiding this comment.
If the user is not logged in then he/she has no navigation to switch to the about page from the TOS.
If the user is logged in, then he/she will find the TOS in the configs section, that has a navigation menu on the left hand side, where the About page is linked to. In the logged-in state the page does not have a footer.
Alkarex
approved these changes
Mar 21, 2023
Alkarex
reviewed
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #5189
Follow up of #5215
Changes proposed in this pull request:
Add the link to the Terms of Service to:
Login screen
Registration form
add the "about FreshRSS" link to the TOS page to keep the sites consistent and having a
<footer>How to test the feature manually:
Pull request checklist: