Use typed access to request parameters #5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a big source of mixed datatypes in many places
Alkarex
commented
Apr 6, 2023
| @@ -35,6 +42,7 @@ public static function params() { | |||
| * @param mixed $default default value, if no parameter is given | |||
| * @param bool $specialchars special characters | |||
| * @return mixed value of the parameter | |||
| * @deprecated use typed versions instead | |||
There was a problem hiding this comment.
Making the previous method deprecated.
Still used in one location: FreshRSS_entry_Controller->readAction()
|
@ColonelMoutarde would you feel like proofreading a bit here? |
|
Let's merge to avoid too many PR conflicts |
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Apr 13, 2023
Fix FreshRSS#5293 Regression from FreshRSS#5267
Merged
Alkarex
commented
Apr 13, 2023
| $shortcuts = Minz_Request::param('shortcuts'); | ||
| if (false !== Minz_Request::param('load_default_shortcuts')) { | ||
| $shortcuts = Minz_Request::paramArray('shortcuts'); | ||
| if (!Minz_Request::paramBoolean('load_default_shortcuts')) { |
There was a problem hiding this comment.
Negation bug fixed in #5294
Alkarex
added a commit
that referenced
this pull request
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a big source of mixed datatypes in many places
Contributes to #4112