Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPstan level 6 for Migrator.php #5283

Merged
merged 9 commits into from Apr 11, 2023
Merged

PHPstan level 6 for Migrator.php #5283

merged 9 commits into from Apr 11, 2023

Conversation

ColonelMoutarde
Copy link
Contributor

@ColonelMoutarde ColonelMoutarde commented Apr 10, 2023 •
edited

Changes proposed in this pull request:

  • PHPstan level 6 for Migrator.php

Pull request checklist:

  • clear commit messages
  • code manually tested

@ColonelMoutarde ColonelMoutarde marked this pull request as draft April 10, 2023 18:09
@ColonelMoutarde ColonelMoutarde marked this pull request as ready for review April 10, 2023 18:12
@Alkarex Alkarex added this to the 1.22.0 milestone Apr 10, 2023
@Alkarex Alkarex added the System care Everything related to the system care label Apr 10, 2023
@Alkarex
Copy link
Member

Alkarex commented Apr 10, 2023

Don't you mean Level 6?

Alkarex
Alkarex reviewed Apr 10, 2023
View reviewed changes
lib/Minz/Migrator.php Outdated Show resolved Hide resolved
Alkarex
Alkarex reviewed Apr 10, 2023
View reviewed changes
lib/Minz/Migrator.php Outdated Show resolved Hide resolved
Alkarex
Alkarex reviewed Apr 10, 2023
View reviewed changes
lib/Minz/Migrator.php Outdated Show resolved Hide resolved
Alkarex
Alkarex reviewed Apr 10, 2023
View reviewed changes
lib/Minz/Migrator.php Outdated Show resolved Hide resolved
@Alkarex
Copy link
Member

Alkarex commented Apr 10, 2023

Contributes to #4112

@ColonelMoutarde ColonelMoutarde changed the title PHPstan level 5 for Migrator.php PHPstan level 6 for Migrator.php Apr 10, 2023
ColonelMoutarde and others added 3 commits April 10, 2023 21:21
@ColonelMoutarde @Alkarex
Update lib/Minz/Migrator.php
e2bb021 
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
@ColonelMoutarde @Alkarex
Update lib/Minz/Migrator.php
de6fea1 
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
@ColonelMoutarde @Alkarex
Update lib/Minz/Migrator.php
23c3473 
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
@ColonelMoutarde
Copy link
Contributor Author

ColonelMoutarde commented Apr 10, 2023 •
edited

Don't you mean Level 6?

you'r right sorry

@Alkarex Alkarex merged commit 594d118 into FreshRSS:edge Apr 11, 2023
1 check passed
@math-GH math-GH mentioned this pull request Apr 11, 2023
Merged
2 tasks
@ColonelMoutarde ColonelMoutarde deleted the feature/phpstan-migrator-class branch May 3, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alkarex Alkarex Alkarex left review comments

Assignees
No one assigned
Labels
System care Everything related to the system care
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ColonelMoutarde @Alkarex