Improve markAsReadUponGone #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix case when the uptream feed has zero article, then old articles would never be automatically marked as read with the "mark as read when gone" policy, which was only based on the timestamp of new articles from the uptream feed.
Needs to be re-tested with SQLite + MySQL
In the case of WebSub, and in the case of invalid GUIDs
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
May 9, 2023
Fix regression from FreshRSS#5315 which indroduced a bug for cached feeds. We now update the `lastSeen` property of entries to account for the fact that they are unchanged but still existing.
Merged
Alkarex
added a commit
that referenced
this pull request
May 9, 2023
Fix regression from #5315 which indroduced a bug for cached feeds. We now update the `lastSeen` property of entries to account for the fact that they are unchanged but still existing.
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
May 15, 2023
FreshRSS#5382 was not good enough to fix markAsReadUponGone and introduced a regression in `entry.lastSeen`. New approach. Follow-up of FreshRSS#5315
math-GH
pushed a commit
to math-GH/FreshRSS
that referenced
this pull request
Jul 4, 2023
Fix regression from FreshRSS#5315 which indroduced a bug for cached feeds. We now update the `lastSeen` property of entries to account for the fact that they are unchanged but still existing.
math-GH
pushed a commit
to math-GH/FreshRSS
that referenced
this pull request
Jul 4, 2023
* Fix again updateLastSeenUnchanged FreshRSS#5382 was not good enough to fix markAsReadUponGone and introduced a regression in `entry.lastSeen`. New approach. Follow-up of FreshRSS#5315 * Minor change of mind * Fix handling of lastSeen entry.lastSeen was not always correctly initialised, and sometimes overriden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix case when the upstream feed has zero article, then old articles would never be automatically marked as read with the "mark as read when gone" policy, which was only based on the timestamp of new articles from the upstream feed.
Fix also bugs in the case of WebSub, and in the case of feeds with invalid (duplicate) GUIDs