phpstan level 7 for feedController.php #5373
Conversation
…ler' into feature/phpstan7-for-feedController
ColonelMoutarde
force-pushed
the
feature/phpstan7-for-feedController
branch
from
2996705
to
4471d92
Compare
| @@ -564,21 +575,21 @@ public static function actualizeFeed(int $feed_id, string $feed_url, bool $force | |||
| } | |||
|
|
|||
| if ($simplePie != null) { | |||
| if ($feed->name(true) == '') { | |||
| if ($feed->name(true) === '') { | |||
There was a problem hiding this comment.
It does not matter much here, but this is another example where === is less safe.
Imagine we change ->name() to return null if undefined or false in case of error (which is quite common), and the new code will lead to a bug, while the previous code was safe.
There was a problem hiding this comment.
It doesn't matter much here, but this is another example where === is less safe.
Let's say we change ->name() so that it returns null if undefined or false on error (which is quite common), and the new code will lead to a bug, whereas the previous code was safe.
Here is the function that is called when we do ->name();
public function name(bool $raw = false): string {
return $raw || $this->name != '' ? $this->name : preg_replace('%^https?://(www[.])?%i', '', $this->url);
}In any case we have a string in output if the function, what you do not want is that your string is of type: ""
There was a problem hiding this comment.
I know what we have now. My point was that it could change, and null / false are quite common
|
A few fixes. Double-check welcome fef7939 |
|
allright for me |
* phpstan level 7 for feedController.php * phpstan level 7 for feedController.php * phpstan level 7 for feedController.php * phpstan level 7 for feedController.php * A few fixes --------- Co-authored-by: Luc <sanchezluc+freshrss@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Changes proposed in this pull request:
Pull request checklist: