Fixed: i18n extensions: 'en' as fallback #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have made a few small changes. Please double-check |
Checked. Works fine. Thanks for your support! |
Alkarex
approved these changes
May 28, 2023
math-GH
added a commit
to math-GH/FreshRSS
that referenced
this pull request
Jul 4, 2023
* Update Translate.php * Small improvements --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
|
Possible regression #5724 (comment) |
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Oct 26, 2023
fix FreshRSS#5734 fix FreshRSS#5724 Regression from FreshRSS#5426
Alkarex
reviewed
Oct 26, 2023
| return; | ||
| if (self::$lang_name === '' || !is_dir($lang_path)) { | ||
| // The lang path does not exist, fallback to English ('en') | ||
| self::$lang_name = 'en'; |
Alkarex
added a commit
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5419 and #5425
If users language not provided by the i18n files of the extension then try to fallback to English, if available.
How to test the feature manually:
see #5419
Pull request checklist: